Skip to content

Commit 408b36b

Browse files
committed
Remove kaminari-activerecord from solidus_core
All transient gems that actually use Kaminari for pagination have it as dependency and this is the right call. Depending on kaminari in core does not make any sense, since core does not hold controllers nor views.
1 parent 20161a3 commit 408b36b

4 files changed

Lines changed: 3 additions & 2 deletions

File tree

api/lib/spree/api.rb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
# frozen_string_literal: true
22

3+
require "kaminari/activerecord"
34
require "spree/core"
45

56
require "spree/api/engine"

core/lib/spree/core.rb

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616
require "awesome_nested_set"
1717
require "cancan"
1818
require "friendly_id"
19-
require "kaminari/activerecord"
2019
require "monetize"
2120
require "paperclip"
2221
require "ransack"

core/lib/spree/core/search/base.rb

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
# frozen_string_literal: true
22

3+
require "kaminari/activerecord"
4+
35
module Spree
46
module Core
57
module Search

core/solidus_core.gemspec

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,6 @@ Gem::Specification.new do |s|
4242
s.add_dependency "discard", "~> 1.0"
4343
s.add_dependency "friendly_id", "~> 5.0"
4444
s.add_dependency "image_processing", "~> 1.10"
45-
s.add_dependency "kaminari-activerecord", "~> 1.1"
4645
s.add_dependency "mini_magick", "~> 4.10"
4746
s.add_dependency "monetize", "~> 1.8"
4847
s.add_dependency "kt-paperclip", [">= 6.3", "< 8"]

0 commit comments

Comments
 (0)