Fix linting errors manually

These were not solved by standardrb --fix.

Author: mamhoff

app/models/solidus_braintree/gateway.rb

@@ -334,9 +334,7 @@ def convert_preference_value(value, type, preference_encryptor = nil)
     end
 
     def transaction_options(source, options, submit_for_settlement: false)
-      params = options.select do |key, _|
-        ALLOWED_BRAINTREE_OPTIONS.include?(key)
-      end
+      params = options.slice(*ALLOWED_BRAINTREE_OPTIONS)
 
       params[:channel] = "Solidus"
       params[:options] = {store_in_vault_on_success: store_in_vault}
@@ -345,15 +343,15 @@ def transaction_options(source, options, submit_for_settlement: false)
         params[:options][:submit_for_settlement] = true
       end
 
-      if paypal_email = paypal_payee_email_for(source, options)
+      if (paypal_email = paypal_payee_email_for(source, options))
         params[:options][:paypal] = {payee_email: paypal_email}
       end
 
       if source.venmo? && venmo_business_profile_id
         params[:options][:venmo] = {profile_id: venmo_business_profile_id}
       end
 
-      if merchant_account_id = merchant_account_for(source, options)
+      if (merchant_account_id = merchant_account_for(source, options))
         params[:merchant_account_id] = merchant_account_id
       end
 

spec/support/solidus_braintree/vcr.rb

@@ -26,7 +26,7 @@
       uri_match_pattern =
         %r{\Ahttps://api\.sandbox\.braintreegateway\.com/merchants/\w+(/.*)\z}
 
-      if match = uri.match(uri_match_pattern)
+      if (match = uri.match(uri_match_pattern))
         match.captures.first
       end
     end