Skip to content

Harden create-release Velopack uploads against transient GitHub transport failures#121

Merged
soliktomasz merged 2 commits into
mainfrom
copilot/fix-create-release-job-again
May 31, 2026
Merged

Harden create-release Velopack uploads against transient GitHub transport failures#121
soliktomasz merged 2 commits into
mainfrom
copilot/fix-create-release-job-again

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 30, 2026

The create-release GitHub Actions job was failing in run 26686864386 (job 78656787270) during vpk upload github with intermittent transport errors (Broken pipe). This change makes release asset publishing resilient to transient upload failures instead of failing the workflow on a single unstable transfer window.

  • Root cause addressed

    • create-release relied on a single vpk upload github invocation per channel, and Velopack’s internal retries were not always sufficient for large asset uploads over unstable connections.
  • Workflow change

    • Added an outer retry loop around vpk upload github in .github/workflows/release.yml.
    • Retries up to 3 attempts with incremental backoff before surfacing a hard failure.
    • Keeps failure behavior explicit when retries are exhausted.
  • Scope

    • Limited to the create-release job upload block; no build/package logic changes.
max_attempts=3
attempt=1
until vpk upload github ...; do
  if [ "$attempt" -ge "$max_attempts" ]; then
    echo "Velopack upload failed after ${max_attempts} attempts."
    exit 1
  fi
  sleep_seconds=$((attempt * 15))
  sleep "$sleep_seconds"
  attempt=$((attempt + 1))
done

Copilot AI changed the title [WIP] Fix failing GitHub Actions job create-release Harden create-release Velopack uploads against transient GitHub transport failures May 30, 2026
Copilot AI requested a review from soliktomasz May 30, 2026 15:43
@soliktomasz soliktomasz marked this pull request as ready for review May 31, 2026 06:21
Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

@soliktomasz soliktomasz merged commit 5caead7 into main May 31, 2026
3 checks passed
@soliktomasz soliktomasz deleted the copilot/fix-create-release-job-again branch May 31, 2026 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants