fix: Update findByIds method to use get() instead of find() for correct query execution

cklei-carly · cklei-carly · commit 4ef8529ff908 · 2025-05-09T12:03:44.000+08:00
diff --git a/src/Services/ContentService.php b/src/Services/ContentService.php
@@ -28,8 +28,7 @@ public function __construct()
     /** {@inheritDoc} */
     public function findByIds($ids, $isWebPage = null, $isPublished = null, $withRelations = [], $sorting = [], $limit = 10)
     {
-        return $this->buildFindByIdsQuery($ids, $isWebPage, $isPublished, $withRelations, $sorting, $limit)
-            ->find($ids);
+        return $this->buildFindByIdsQuery($ids, $isWebPage, $isPublished, $withRelations, $sorting, $limit)->get();
     }
 
     public function findByRoutePatternWithLangId($uri, $isDefaultRoutePattern, $isWebPage = null, $isPublished = null, $withRelations = [], $sorting = [], $limit = 10)
@@ -310,7 +309,7 @@ private function buildFindByIdsQuery($ids, $isWebPage = null, $isPublished = nul
         ]);
         $query = $this->applySortingAndLimit($query, $sorting, $limit);
 
-        return $query;
+        return $query->whereKey($ids);
     }
 
     private function buildFindByRealPathQuery($path, $isWebPage = null, $isPublished = null, $withRelations = [], $sorting = [], $limit = null)

Original file line number	Diff line number	Diff line change
`@@ -28,8 +28,7 @@ public function __construct()`
`28`	`28`	`/** {@inheritDoc} */`
`29`	`29`	`public function findByIds($ids, $isWebPage = null, $isPublished = null, $withRelations = [], $sorting = [], $limit = 10)`
`30`	`30`	`{`
`31`		`- return $this->buildFindByIdsQuery($ids, $isWebPage, $isPublished, $withRelations, $sorting, $limit)`
`32`		`- ->find($ids);`
	`31`	`+ return $this->buildFindByIdsQuery($ids, $isWebPage, $isPublished, $withRelations, $sorting, $limit)->get();`
`33`	`32`	`}`
`34`	`33`
`35`	`34`	`public function findByRoutePatternWithLangId($uri, $isDefaultRoutePattern, $isWebPage = null, $isPublished = null, $withRelations = [], $sorting = [], $limit = 10)`
`@@ -310,7 +309,7 @@ private function buildFindByIdsQuery($ids, $isWebPage = null, $isPublished = nul`
`310`	`309`	`]);`
`311`	`310`	`$query = $this->applySortingAndLimit($query, $sorting, $limit);`
`312`	`311`
`313`		`- return $query;`
	`312`	`+ return $query->whereKey($ids);`
`314`	`313`	`}`
`315`	`314`
`316`	`315`	`private function buildFindByRealPathQuery($path, $isWebPage = null, $isPublished = null, $withRelations = [], $sorting = [], $limit = null)`