Skip to content

Commit 3b913ba

Browse files
committed
Remove the below from the Known Issues section as it was addressed:
4. Currently all levels of unordered lists use a dash for the bullet. This is a planned fix; [see here](#1).
1 parent ca7e9c4 commit 3b913ba

2 files changed

Lines changed: 8 additions & 15 deletions

File tree

README.md

Lines changed: 5 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -181,18 +181,11 @@ and data provided in each while the AST is presented.
181181
182182
## Limitations and Known Issues
183183
184-
1. It is common for Markdown to include HTML. HTML is treated as a "code block". *There is no attempt to convert raw HTML to PDF.*
185-
186-
2. Github-flavored Markdown permits strikethough using tildes. This is not supported at present by `fpdf` as a font style.
187-
188-
3. The markdown link title, which would show when converted to HTML as hover-over text, is not supported. The generated PDF will show the actual URL that will be used if clicked, but this is a function of the PDF viewer.
189-
190-
4. Currently all levels of unordered lists use a dash for the bullet.
191-
This is a planned fix; [see here](https://github.com/solworktech/mdtopdf/issues/1).
192-
193-
5. Definition lists are not supported (not sure that markdown supports them -- I need to research this)
194-
195-
6. The following text features may be tweaked: font, size, spacing, style, fill color, and text color. These are exported and available via the `Styler` struct. Note that fill color only works when using `CellFormat()`. This is the case for: tables, codeblocks, and backticked text.
184+
- It is common for Markdown to include HTML. HTML is treated as a "code block". *There is no attempt to convert raw HTML to PDF.*
185+
- Github-flavored Markdown permits strikethough using tildes. This is not supported at present by `fpdf` as a font style.
186+
- The markdown link title, which would show when converted to HTML as hover-over text, is not supported. The generated PDF will show the actual URL that will be used if clicked, but this is a function of the PDF viewer.
187+
- Definition lists are not supported (not sure that markdown supports them -- I need to research this)
188+
- The following text features may be tweaked: font, size, spacing, style, fill color, and text color. These are exported and available via the `Styler` struct. Note that fill color only works when using `CellFormat()`. This is the case for: tables, codeblocks, and backticked text.
196189
197190
198191
### Post release note

nodeProcessing.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -244,10 +244,10 @@ func (r *PdfRenderer) processItem(node ast.ListItem, entering bool) {
244244
bulletChar := tr("•")
245245
currFontSize, _ := r.Pdf.GetFontSize()
246246
if node.BulletChar != 45 { // if the bullet char is not '-'
247-
bulletChar = tr("▪")
248-
r.Pdf.SetFont("", "", 25)
247+
bulletChar = tr("▪")
248+
r.Pdf.SetFont("", "", 25)
249249
}
250-
r.Pdf.CellFormat(4*r.em, r.Normal.Size + r.Normal.Spacing,
250+
r.Pdf.CellFormat(4*r.em, r.Normal.Size+r.Normal.Spacing,
251251
bulletChar,
252252
"", 0, "RB", false, 0, "")
253253
r.Pdf.SetFont("", "", currFontSize)

0 commit comments

Comments
 (0)