fix(compat): replace str_starts_with with strncmp for PHP 7.4

PhpSyntaxTest.php used str_starts_with() (PHP 8.0+) which would fatal
under PHP 7.4 before any assertion ran. Use strncmp() instead.

Also remove redundant (int) cast and double in_array check on
drp_action in notify_lists.php: get_filter_request_var() already
validated the value; the second clause was dead and confusing.

Replace count() with cacti_sizeof() in setup.php bulk loop.

Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>

Author: somethingwithproof

notify_lists.php

@@ -150,8 +150,7 @@ function form_actions() {
 
 	$valid_actions = array_keys($actions + $assoc_actions);
 
-	if (!in_array(get_request_var('drp_action'), $valid_actions, true) &&
-		!in_array((int) get_request_var('drp_action'), $valid_actions, true)) {
+	if (!in_array(get_request_var('drp_action'), $valid_actions, true)) {
 		raise_message(40);
 		header('Location: notify_lists.php');
 		exit;

setup.php

@@ -691,7 +691,7 @@ function thold_device_action_execute($action) {
 	$selected_items = sanitize_unserialize_selected_items(get_nfilter_request_var('selected_items'));
 
 	if ($selected_items != false) {
-		for ($i = 0; ($i < count($selected_items)); $i++) {
+		for ($i = 0; ($i < cacti_sizeof($selected_items)); $i++) {
 			autocreate($selected_items[$i]);
 		}
 	}

tests/Smoke/PhpSyntaxTest.php

@@ -30,11 +30,11 @@
 
 	$rel = ltrim(str_replace($root, '', $file->getPathname()), DIRECTORY_SEPARATOR);
 
-	if (str_starts_with($rel, 'vendor' . DIRECTORY_SEPARATOR)) {
+	if (strncmp($rel, 'vendor' . DIRECTORY_SEPARATOR, strlen('vendor' . DIRECTORY_SEPARATOR)) === 0) {
 		continue;
 	}
 
-	if (str_starts_with($rel, 'tests' . DIRECTORY_SEPARATOR)) {
+	if (strncmp($rel, 'tests' . DIRECTORY_SEPARATOR, strlen('tests' . DIRECTORY_SEPARATOR)) === 0) {
 		continue;
 	}