hotfix to solve esp-idf 5.3 compatibily with ESP32-C3#197
Open
siteswapjuggler wants to merge 1 commit into
Open
hotfix to solve esp-idf 5.3 compatibily with ESP32-C3#197siteswapjuggler wants to merge 1 commit into
siteswapjuggler wants to merge 1 commit into
Conversation
septatrix
reviewed
Jul 25, 2025
| struct dmx_uart_t *uart = &dmx_uart_context[dmx_num]; | ||
| if (uart->num != 0) { // Default UART port for console | ||
| #if ESP_IDF_VERSION >= ESP_IDF_VERSION_VAL(5, 3, 0) | ||
| periph_module_disable(PERIPH_UART1_MODULE+dmx_num); |
There was a problem hiding this comment.
This one is different from the rest. Shouldn't is just use PERIPH_UART0_MODULE+uart->num to be consistent with the variant below?
|
I don’t know which code you are comparing to, did you see the latest I relezsed to support 5.3 and 5.4 ?
Attached
From: Nils K ***@***.***>
Sent: Friday, July 25, 2025 2:48 PM
To: someweisguy/esp_dmx ***@***.***>
Cc: Subscribed ***@***.***>
Subject: Re: [someweisguy/esp_dmx] hotfix to solve esp-idf 5.3 compatibily with ESP32-C3 (PR #197)
@septatrix commented on this pull request.
_____
In src/dmx/hal/uart.c <#197 (comment)> :
@@ -381,7 +393,11 @@ bool dmx_uart_init(dmx_port_t dmx_num, void *isr_context, int isr_flags) {
void dmx_uart_deinit(dmx_port_t dmx_num) {
struct dmx_uart_t *uart = &dmx_uart_context[dmx_num];
if (uart->num != 0) { // Default UART port for console
+ #if ESP_IDF_VERSION >= ESP_IDF_VERSION_VAL(5, 3, 0)
+ periph_module_disable(PERIPH_UART1_MODULE+dmx_num);
This one is different from the rest. Shouldn't is just use PERIPH_UART0_MODULE+uart->num to be consistent with the variant below?
—
Reply to this email directly, view it on GitHub <#197 (review)> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABIKT5SIB3RNRRONHFU6JV33KJ3XVAVCNFSM6AAAAABZY23HZOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTANJWGQ3TQMRXGY> .
You are receiving this because you are subscribed to this thread. <https://github.com/notifications/beacon/ABIKT5TZGI4NUUM2BXEEQ5D3KJ3XVA5CNFSM6AAAAABZY23HZOWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTVWFYUEI.gif> Message ID: ***@***.*** ***@***.***> >
|
The first change (replacing enum member with define) is already included in the latest release but the other change (replacing the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix compatibility with ESP-IDF >= 5.3
ESP-IDF 5.3 removed the
modulefield fromuart_signal_conn_t. This patch replaces it with a version-safe reference toPERIPH_UARTx_MODULEwhich seems to have been normalised in the new ESP-IDF iteration.Conditionnal MACRO are use to keep compatibility with both ESP-IDF 5.1 and 5.3.
Tested with: