fix: set CHROME_BIN for Chrome in CI (#44)

* fix: set CHROME_BIN for Chrome in CI

* revert: CI workflow to original simple configuration

- Remove unnecessary Chrome setup steps (ubuntu-latest has Chrome pre-installed)
- Remove CHROME_BIN environment variable setup
- Remove SKIP_BROWSER_TESTS (browser tests should run)
- Revert browser.rs --no-sandbox changes

This restores the CI configuration that was working in commit 7ba3223 (v0.1.0).

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

* fix: properly configure Chrome path in CI using config file

- Add Chrome setup step that verifies Chrome/Chromium existence
- Create config file with browser_path pointing to pre-installed Chrome
- Increase Chrome startup timeout from 10s to 30s for slower CI environments
- Update troubleshooting message to suggest using config command

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

* fix: apply Chrome config setup to release workflow as well

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: sonesuke

.github/workflows/ci.yml

@@ -23,8 +23,29 @@ jobs:
         with:
           components: rustfmt, clippy
 
-      - name: Setup Chrome
-        uses: browser-actions/setup-chrome@v1
+      - name: Setup Chrome configuration
+        run: |
+          # Check if Chrome exists in standard locations
+          if [ -f "/usr/bin/google-chrome" ]; then
+            CHROME_PATH="/usr/bin/google-chrome"
+          elif [ -f "/usr/bin/chromium-browser" ]; then
+            CHROME_PATH="/usr/bin/chromium-browser"
+          else
+            echo "ERROR: Chrome/Chromium not found"
+            exit 1
+          fi
+
+          echo "Found Chrome at: $CHROME_PATH"
+          $CHROME_PATH --version
+
+          # Create config directory and set browser path
+          mkdir -p ~/.config/google-patent-cli
+          cat > ~/.config/google-patent-cli/config.toml << EOF
+          browser_path = "$CHROME_PATH"
+          EOF
+
+          echo "Config file created:"
+          cat ~/.config/google-patent-cli/config.toml
 
       - name: Check formatting
         run: cargo fmt -- --check

.github/workflows/release.yml

@@ -21,8 +21,29 @@ jobs:
         with:
           components: rustfmt, clippy
 
-      - name: Setup Chrome
-        uses: browser-actions/setup-chrome@v1
+      - name: Setup Chrome configuration
+        run: |
+          # Check if Chrome exists in standard locations
+          if [ -f "/usr/bin/google-chrome" ]; then
+            CHROME_PATH="/usr/bin/google-chrome"
+          elif [ -f "/usr/bin/chromium-browser" ]; then
+            CHROME_PATH="/usr/bin/chromium-browser"
+          else
+            echo "ERROR: Chrome/Chromium not found"
+            exit 1
+          fi
+
+          echo "Found Chrome at: $CHROME_PATH"
+          $CHROME_PATH --version
+
+          # Create config directory and set browser path
+          mkdir -p ~/.config/google-patent-cli
+          cat > ~/.config/google-patent-cli/config.toml << EOF
+          browser_path = "$CHROME_PATH"
+          EOF
+
+          echo "Config file created:"
+          cat ~/.config/google-patent-cli/config.toml
 
       - name: Check formatting
         run: cargo fmt -- --check

Cargo.lock

@@ -86,8 +86,8 @@ impl CdpBrowser {
         // Spawn a thread to read stderr and look for the port
         tokio::spawn(async move {
             let start = std::time::Instant::now();
-            // Try for up to 10 seconds
-            while start.elapsed().as_secs() < 10 {
+            // Try for up to 30 seconds (CI environments may be slower)
+            while start.elapsed().as_secs() < 30 {
                 if let Ok(content) = std::fs::read_to_string(&stderr_path) {
                     for line in content.lines() {
                         if debug_flag {
@@ -113,9 +113,9 @@ impl CdpBrowser {
 
         let stderr_path_for_error = stderr_file.clone();
         let process_ext = process.clone();
-        // Wait for the port to be discovered (up to 10 seconds)
+        // Wait for the port to be discovered (up to 30 seconds for slower CI environments)
         let discovered_port = tokio::task::spawn_blocking(move || {
-            for _ in 0..100 {
+            for _ in 0..300 {
                 let port_val = port.lock().map_or(None, |guard| *guard);
 
                 if let Some(p) = port_val {
@@ -157,12 +157,12 @@ impl CdpBrowser {
                 err_msg = format!("{}\n\nChrome process exited early with status: {}", err_msg, status);
             } else {
                 err_msg = format!(
-                    "{}\n\nChrome process is still running but debugging port was not found after 10 seconds.\n\n\
+                    "{}\n\nChrome process is still running but debugging port was not found after 30 seconds.\n\n\
                      Troubleshooting:\n\
                      - If running in CI, ensure Chrome/Chromium is installed and accessible\n\
                      - Check if Chrome requires additional flags (e.g., --no-sandbox for Linux CI)\n\
                      - Verify the temp directory is writable\n\
-                     - Try running with CHROME_BIN=/usr/bin/google-chrome-stable (or appropriate path)",
+                     - Try using 'config --set-browser' to specify the correct Chrome path",
                     err_msg
                 );
             }