feat: add empty results test and improve devcontainer config (#74)

* fix: handle empty search results by creating fallback dataset

When search returns 0 results, CypherEngine::from_json_auto fails
to create a graph, causing the dataset to not be stored. This leads
to "Dataset not found" errors when execute_cypher is called, forcing
the AI agent to fall back to reading the JSON file directly.

This commit fixes the issue by creating a minimal fallback dataset
with a dummy node when the engine creation fails.

Additionally:
- Add logs/ and .skill-bench/ to .gitignore
- Update mise.toml to run cargo install before skill-test
- Increase timeout for patent-assignee-check/triggering test
- Install skill-bench in devcontainer setup

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* feat: add empty results test and improve devcontainer config

- Add functional-empty.toml test case for handling empty search results
- Update Cargo.lock to version 0.2.0
- Format devcontainer.json with trailing commas
- Add GitHub CLI config mount to devcontainer

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: sonesuke

.devcontainer/devcontainer.json

@@ -1,27 +1,30 @@
 {
-	"name": "Google-Patent-CLI Dev",
-	"build": {
-		"dockerfile": "Dockerfile",
-		"context": ".."
-	},
-	"features": {
-		"ghcr.io/devcontainers/features/common-utils:2": {
-			"installZsh": "true",
-			"username": "vscode",
-			"userUid": "1000",
-			"userGid": "1000",
-			"upgradePackages": "false"
-		},
-		"ghcr.io/devcontainers/features/github-cli:1": {},
-		"ghcr.io/devcontainers/features/git:1": {}
-	},
-	"customizations": {
-		"vscode": {}
-	},
-	"containerEnv": {
-		"Z_AI_API_KEY": "${localEnv:Z_AI_API_KEY}",
-		"CLAUDE_CODE_EXPERIMENTAL_AGENT_TEAMS": "1"
-	},
-	"postCreateCommand": "bash .devcontainer/post-create.sh",
-	"remoteUser": "vscode"
-}
+  "name": "Google-Patent-CLI Dev",
+  "build": {
+    "dockerfile": "Dockerfile",
+    "context": "..",
+  },
+  "features": {
+    "ghcr.io/devcontainers/features/common-utils:2": {
+      "installZsh": "true",
+      "username": "vscode",
+      "userUid": "1000",
+      "userGid": "1000",
+      "upgradePackages": "false",
+    },
+    "ghcr.io/devcontainers/features/github-cli:1": {},
+    "ghcr.io/devcontainers/features/git:1": {},
+  },
+  "mounts": [
+    "source=${localEnv:HOME}/.config/gh,target=/home/vscode/.config/gh,type=bind,consistency=cached",
+  ],
+  "customizations": {
+    "vscode": {},
+  },
+  "containerEnv": {
+    "Z_AI_API_KEY": "${localEnv:Z_AI_API_KEY}",
+    "CLAUDE_CODE_EXPERIMENTAL_AGENT_TEAMS": "1",
+  },
+  "postCreateCommand": "bash .devcontainer/post-create.sh",
+  "remoteUser": "vscode",
+}

.devcontainer/post-create.sh

@@ -41,6 +41,14 @@ EOF
     echo 'eval "$(mise activate bash)"' >> $HOME/.bashrc
     echo 'eval "$(mise activate zsh)"' >> $HOME/.zshrc
 
+    # Install skill-bench
+    if ! command -v skill-bench >/dev/null 2>&1; then
+        echo "[Devcontainer Setup] Installing skill-bench..."
+        curl -fsSL https://raw.githubusercontent.com/sonesuke/skill-bench/main/scripts/setup.sh | sh
+    else
+        echo "[Devcontainer Setup] skill-bench already installed: $(skill-bench --version 2>/dev/null || echo 'unknown')"
+    fi
+
     # Configure google-patent-cli to use chromium
     # Note: chrome_args will be dynamically determined by the app
     echo "[Devcontainer Setup] Configuring google-patent-cli..."

.gitignore

@@ -2,3 +2,5 @@
 debug_page.html
 patent_page_dom.html
 .claude/worktrees/
+logs/
+.skill-bench/

Cargo.lock

@@ -11,7 +11,7 @@ run = "RUSTFLAGS=\"-D warnings\" cargo test --all-targets"
 depends = ["fmt", "clippy", "test"]
 
 [tasks.skill-test]
-run = "skill-bench run tests --plugin-dir claude-plugin --log logs"
+run = "cargo install --path . && skill-bench run tests --plugin-dir claude-plugin --log logs"
 
 [tasks.skill-test-list]
 run = "skill-bench list tests"

mise.toml

@@ -14,6 +14,7 @@ use rmcp::{
 };
 use serde::{Deserialize, Serialize};
 use serde_json::Value;
+use serde_json::json;
 use std::collections::HashMap;
 use std::hash::{DefaultHasher, Hash, Hasher};
 use std::sync::Arc;
@@ -231,11 +232,27 @@ impl PatentHandler {
         json: &Value,
         root_label: Option<&str>,
     ) -> Option<String> {
-        let engine = if let Some(label) = root_label {
-            CypherEngine::from_json_auto_as_root_with_label(json, label).ok()?
+        // Try to create engine from the provided JSON
+        let engine_result = if let Some(label) = root_label {
+            CypherEngine::from_json_auto_as_root_with_label(json, label)
         } else {
-            CypherEngine::from_json_auto(json).ok()?
+            CypherEngine::from_json_auto(json)
         };
+
+        let engine = match engine_result {
+            Ok(e) => e,
+            Err(_) => {
+                // If failed (e.g., empty results), create a minimal valid graph
+                // Create a dummy node that CypherEngine can parse
+                let fallback_json = if let Some(label) = root_label {
+                    json!({ label: [{"id": "_dummy", "_label": label }] })
+                } else {
+                    json!({ "Patent": [{"id": "_dummy", "title": "", "url": ""}] })
+                };
+                CypherEngine::from_json_auto(&fallback_json).ok()?
+            }
+        };
+
         let graph_schema = engine.get_schema();
 
         // Store the engine

src/mcp/mod.rs

@@ -2,7 +2,7 @@
 
 name = "triggering"
 description = "Verify patent-assignee-check skill is triggered when checking assignee variations"
-timeout = 120
+timeout = 300
 
 test_prompt = """
 I want to verify the correct assignee name for "Salesforce" in patent databases.

tests/patent-assignee-check/triggering.toml

@@ -0,0 +1,30 @@
+# Test Case: Patent Search - Empty Results
+
+name = "functional-empty"
+description = "Verify patent-search skill handles empty search results correctly"
+timeout = 120
+
+test_prompt = """
+Search for patents with query "xyz-nonexistent-patent-123" and limit 5.
+Then use execute_cypher to query the dataset.
+"""
+
+[[checks]]
+name = "mcp_server_loaded"
+command = { command = "mcp-loaded", server = "google-patent-cli" }
+
+[[checks]]
+name = "skill_loaded"
+command = { command = "skill-loaded", skill = "patent-search" }
+
+[[checks]]
+name = "patent_search_skill_invoked"
+command = { command = "skill-invoked", skill = "patent-search" }
+
+[[checks]]
+name = "search_patents_mcp_called"
+command = { command = "mcp-success", tool = "search_patents" }
+
+[[checks]]
+name = "execute_cypher_mcp_called"
+command = { command = "mcp-success", tool = "execute_cypher" }