[HLD] Add support for port loopback#2298
[HLD] Add support for port loopback#2298Keshavg-marvell wants to merge 1 commit intosonic-net:masterfrom
Conversation
|
/azp run |
|
No pipelines are associated with this pull request. |
There was a problem hiding this comment.
Pull request overview
Adds a new High Level Design (HLD) document for supporting port-level loopback mode configuration in SONiC, including architecture/flow diagrams and proposed CLI/DB/SAI/YANG interactions.
Changes:
- Adds an HLD Markdown document describing port loopback modes, DB schema updates, and sequence flows.
- Adds draw.io-generated diagrams for port loopback modes and architectural flow.
- Documents CLI commands, SAI API usage, and a unit test plan for downstream implementation repos.
Reviewed changes
Copilot reviewed 1 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| doc/port-loopback/Port_Loopback_HLD.md | Defines the port loopback feature HLD: requirements, DB schema, SAI API usage, CLI/YANG, warmboot/fastboot impact, and test plan. |
| doc/port-loopback/port_loopback_architectural_flow.png | Architectural flow diagram (draw.io PNG with embedded mxfile). |
| doc/port-loopback/port_loopback_diagram.png | Representational diagram of port loopback modes (draw.io PNG with embedded mxfile). |
e5f0cd6 to
8348a9f
Compare
|
/azp run |
|
No pipelines are associated with this pull request. |
Signed-off-by: Keshav Gupta <keshavg@marvell.com>
8348a9f to
68330da
Compare
|
/azp run |
|
No pipelines are associated with this pull request. |
| @@ -0,0 +1,421 @@ | |||
| # Port Loopback Mode in SONiC | |||
There was a problem hiding this comment.
Can we include gearbox also in the design, to avoid another HLD later. That way we can conclude on the CLI and basic methodology
|
Capturing comments from community L1 meeting: Notes from @keshav. Currently, SAI does not define a port level capability attribute for loopback modes, unlike other port capabilities such as FEC mode, which are exposed via attributes like SAI_PORT_ATTR_SUPPORTED_FEC_MODE. so |
|
Notes from @prgeor @eddyk-nvidia Querying capability per port on large-radix switches (128, 512, or even 1K ports) would be expensive, and suggested exploring to use SAI-level bulk capability query that returns all port capabilities in one call. |
Add support for port loopback