Skip to content

Commit decd2be

Browse files
[temp]: Fix Micas plat_sysfs parallel build race
The plat_sysfs/Makefile lists dev_cfg and dev_sysfs as prerequisites of 'all' but declares no ordering between them. Under make -j (SONiC uses -j12 by default) the two subdirs can build in parallel and the modpost step in dev_sysfs fails with: dev_cfg/Module.symvers: No such file or directory because dev_sysfs/Makefile's KBUILD_EXTRA_SYMBOLS references that file. Adding 'dev_sysfs: dev_cfg' forces dev_cfg to finish first. Temporary patch on this branch so verification builds for the SBOM work complete reliably. Drop this commit (git rebase --onto) once an equivalent upstream fix lands. Signed-off-by: Brad House <bhouse@nexthop.ai>
1 parent a8ba23b commit decd2be

1 file changed

Lines changed: 7 additions & 0 deletions

File tree

  • platform/broadcom/sonic-platform-modules-micas/common/modules/plat_sysfs

platform/broadcom/sonic-platform-modules-micas/common/modules/plat_sysfs/Makefile

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,13 @@ all : CHECK $(SUBDIRS)
88
CHECK :
99
@echo $(pes_parent_dir)
1010

11+
# dev_sysfs's modpost step reads dev_cfg/Module.symvers (see
12+
# dev_sysfs/Makefile's KBUILD_EXTRA_SYMBOLS). Without an explicit
13+
# ordering dependency, make -j can launch dev_sysfs in parallel with
14+
# dev_cfg and the modpost step fails with:
15+
# dev_cfg/Module.symvers: No such file or directory
16+
dev_sysfs: dev_cfg
17+
1118
$(SUBDIRS):ECHO
1219
#@echo $@
1320
make -C $@

0 commit comments

Comments
 (0)