Revert "Upgrade PMON to trixie"#27668
Closed
xwjiang-ms wants to merge 1 commit into
Closed
Conversation
This reverts commit 997516e.
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
There was a problem hiding this comment.
Pull request overview
Reverts the previous change that moved the PMON (platform-monitor) container build to Debian trixie, restoring it to the Debian bookworm build flow used by the rest of the bookworm image pipeline.
Changes:
- Switch PMON build dependencies/load-dockers from
docker-config-engine-trixieback todocker-config-engine-bookworm. - Update PMON Dockerfile base image and Debian package names to the bookworm equivalents (e.g.,
librrd8vslibrrd8t64) and revert grpcio/grpcio-tools pins to the bookworm-aligned versions. - Move PMON registration from
SONIC_TRIXIE_DOCKERStoSONIC_BOOKWORM_DOCKERS.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| rules/docker-platform-monitor.mk | Reverts PMON’s build to bookworm by restoring bookworm config-engine deps and docker registration variables. |
| dockers/docker-platform-monitor/Dockerfile.j2 | Reverts PMON’s base image/packages to bookworm and adjusts package/version pins accordingly. |
saiarcot895
requested changes
Jun 3, 2026
saiarcot895
left a comment
saiarcot895
left a comment
Contributor
There was a problem hiding this comment.
What is the actual error here when running show mux status? Were there any processes not running?
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
Hi @saiarcot895, the current internal dualtor image is broken, here is the error: |
Contributor
|
Fix for this should be in #27698. Testing is pending. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #26923
#26923 (PMON → Trixie) breaks dualtor pretest from 2026-05-29 onward.
show mux statusreturns rc=1 withcould not retrieve key state value for port EthernetX inside table MUX_CABLE_TABLE— the row exists in STATE_DB, but thestatefield is never written.Root cause:
MUX_CABLE_TABLE:stateis published byy_cable_helper(xcvrd subprocess) inside the pmon container. Moving pmon from Bookworm to Trixie bumps Python 3.11 → 3.13 (whereimpis removed — same breakage already patched insonic-bmcctldvia #27557), flipslibrrd8→librrd8t64, jumps grpcio 1.51 → 1.67, and changes thesmartmontools source. Anything in xcvrd / y_cable_helper that wasn't rebuilt against Trixie's libs ImportErrors at container start, so mux state never propagates.
Failing baseline:
https://elastictest.org/scheduler/testplan/6a19eb5c9262108863d7b5bd?testcase=test_pretest.py%7C%7C%7Cvms-kvm-dual-t0_australiaeast_213252&type=console
Verify by using the image built by this PR, testplan link:
https://elastictest.org/scheduler/testplan/6a1ec649729d944bd21c8fb5?testcase=test_pretest.py%7C%7C%7Cvms-kvm-dual-t0_australiaeast_216606&type=console
PMON Trixie migration to be re-attempted once xcvrd / y_cable_helper
Python 3.13 compatibility is fixed.