[interfaces.j2]: Remove syslog policy routing rules from interfaces template#28092
Open
Bojun-Feng wants to merge 1 commit into
Open
[interfaces.j2]: Remove syslog policy routing rules from interfaces template#28092Bojun-Feng wants to merge 1 commit into
Bojun-Feng wants to merge 1 commit into
Conversation
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…emplate * Remove SYSLOG_SERVER ip rule block added by PR sonic-net#20340 and VRF gate added by PR sonic-net#27068 * Remove hardcoded 10.20.6.16 fallback rule and associated test expectations Signed-off-by: Bojun-Feng <bojundf@gmail.com>
Bojun-Feng
force-pushed
the
bug/revert-syslog-iprule-block
branch
from
c31b030 to
7c81400
Compare
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azpw retry |
Collaborator
|
Retrying failed(or canceled) jobs... |
Collaborator
|
Retrying failed(or canceled) stages in build 1149005: ✅Stage Test:
|
Collaborator
|
This PR has backport request for branch(es): 202505,202511,202605. ---Powered by SONiC BuildBot
|
Contributor
Author
|
Hi @tirupatihemanth, for context @wen587's last activity on this repo was Oct 2025, so they may not be reachable for review. The commit message for PR #20340 says the intent was to align the ip rule with the syslog server IP (paralleling NTP/TACACS forced_mgmt_routes). The HLD scopes this differently, so I believe the removal is safe regardless of original intent. Happy to wait if you'd like more time for input. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
files/image_config/interfaces/interfaces.j2installs policy routing rules (ip rule add pref 32764 to <server>/32 table <vrf_table>) for every SYSLOG_SERVER entry at boot time. This implementation followed the existingforced_mgmt_routesmechanism, but the Syslog Source IP HLD (Section 2.3.1) scopes syslog configuration exclusively torsyslog.conf.j2and does not authorizeinterfaces.j2modifications.For the unset-VRF case, the rule hijacks data-plane traffic to the management routing table after reboot (issue #27043). For the mgmt-VRF case, rsyslog.conf.j2 already handles VRF routing via
Device="mgmt"(SO_BINDTODEVICE), making the ip rule redundant.This PR removes the syslog block.
How I did it
How to verify it
src/sonic-config-engine/tests/test_j2files.py, all interfaces test cases should pass with updated expectationsconfig save && rebootand confirmip rule showhas no pref 32764 entries for syslog server IPsDevice="mgmt"socket bindingWhich release branch to backport (provide reason below if selected)
Description for the changelog
Remove redundant syslog policy routing rules from interfaces.j2 that conflict with data-plane routing after reboot