yang: support VLAN subinterfaces for BGP unnumbered#28095
Open
sudharr86 wants to merge 2 commits into
Open
Conversation
Allow VLAN_SUB_INTERFACE entries to carry ipv6_use_link_local_only, matching the existing interface tables. Add YANG model tests for a valid enable value and an invalid boolean-like value. Signed-off-by: Sudharsan Rajagopalan <203154411+sudharr86@users.noreply.github.com>
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Allow a BGP neighbor to reference a VLAN subinterface by adding the VLAN subinterface YANG module import and a leafref to the neighbor union type. Signed-off-by: Sudharsan Rajagopalan <203154411+sudharr86@users.noreply.github.com>
Collaborator
|
/azp run Azure.sonic-buildimage |
sudharr86
changed the title
|
Azure Pipelines successfully started running 1 pipeline(s). |
sudharr86
requested review from
dgsudharsan,
praveen-li,
qiluo-msft and
venkatmahalingam
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add YANG model support needed for BGP unnumbered over VLAN subinterfaces.
Why
VLAN subinterfaces need schema support for IPv6 link-local-only mode and for use as BGP neighbors. This lets configuration validation accept the link-local mode used by the CLI and neighbor-sync changes, and allows BGP neighbor entries to reference VLAN subinterfaces.
Changes
ipv6_use_link_local_onlyunderVLAN_SUB_INTERFACE_LIST.enablevalue and an invalid boolean-like value.BGP_NEIGHBOR_LISTneighbors to reference VLAN subinterface names.Related
Validation
git diff --check upstream/master..HEADpython3 -m json.tool src/sonic-yang-models/tests/yang_model_tests/tests/vlan_sub_interface.jsonpython3 -m json.tool src/sonic-yang-models/tests/yang_model_tests/tests_config/vlan_sub_interface.json