[dhcp-relay] Change default DHCPv4 relay from isc to sonic-dhcpv4-relay#28115
Open
ashutosh-agrawal wants to merge 1 commit into
Open
[dhcp-relay] Change default DHCPv4 relay from isc to sonic-dhcpv4-relay#28115ashutosh-agrawal wants to merge 1 commit into
ashutosh-agrawal wants to merge 1 commit into
Conversation
Change the default DHCPv4 relay implementation from isc-dhcpv4-relay to sonic-dhcpv4-relay in both the YANG model and the runtime dhcprelayd fallback, so devices without an explicit has_sonic_dhcpv4_relay setting use sonic-dhcpv4-relay out of the box. Signed-off-by: Ashutosh Agrawal <ashu@cisco.com>
ashutosh-agrawal
requested review from
dgsudharsan,
lguohan,
praveen-li,
qiluo-msft and
venkatmahalingam
as code owners
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
Change the default DHCPv4 relay implementation from isc-dhcpv4-relay to sonic-dhcpv4-relay. Devices that do not explicitly set
has_sonic_dhcpv4_relayinDEVICE_METADATA(e.g. old configs that pre-date the feature) should now default to sonic-dhcpv4-relay.Work item tracking
How I did it
Two places enforce the default when
has_sonic_dhcpv4_relayis absent:src/sonic-yang-models/yang-models/sonic-device_metadata.yang) —default "false"→default "true", governs the value emitted bysonic-cfggen.src/sonic-dhcp-utilities/dhcp_utilities/dhcprelayd/dhcprelayd.py) —.get("has_sonic_dhcpv4_relay", "False")→.get("has_sonic_dhcpv4_relay", "True"), governs behavior when the key is missing from ConfigDB at runtime.Devices that explicitly set
has_sonic_dhcpv4_relay: falseare unaffected.How to verify it
On a device with no
has_sonic_dhcpv4_relaykey inDEVICE_METADATA, confirm thatdhcprelaydstarts sonic-dhcpv4-relay instead ofdhcrelay(isc).Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Change default DHCPv4 relay from isc-dhcpv4-relay to sonic-dhcpv4-relay.
Link to config_db schema for YANG module changes
https://github.com/Azure/sonic-buildimage/blob/master/src/sonic-yang-models/doc/Configuration.md
A picture of a cute animal (not mandatory but encouraged)