liquid cooling: add defaults for sensor properties (#673)

This prevents DB write faults when the methods are not implemented.

Signed-off-by: Fraser Gordon <fraserg@arista.com>

Author: fraserg-arista

sonic_platform_base/liquid_cooling_base.py

@@ -32,8 +32,8 @@ def __init__(self,
         self.name: str = name
         self.leaking: bool = False
         self.leak_sensor_ok: bool = True
-        self.leak_type: str|None = type
-        self.leak_location = location
+        self.leak_type: str = type or 'unknown'
+        self.leak_location: str = location or 'unknown'
         self.leak_severity = severity
 
     def get_name(self) -> str:
@@ -64,7 +64,7 @@ def is_leak_sensor_ok(self) -> bool:
         """
         return self.leak_sensor_ok
 
-    def get_leak_sensor_type(self) -> str|None:
+    def get_leak_sensor_type(self) -> str:
         """
         Retrieves the leak sensor type
 
@@ -73,7 +73,7 @@ def get_leak_sensor_type(self) -> str|None:
         """
         return self.leak_type
 
-    def get_leak_sensor_location(self) -> str|None:
+    def get_leak_sensor_location(self) -> str:
         """
         Retrieves the location of leak sensor
 

tests/liquid_cooling_base_test.py

@@ -23,8 +23,8 @@ def test_leakage_sensor_base_init():
         leakage_sensor = LeakageSensorBase("test_sensor")
 
         assert leakage_sensor.get_name() == "test_sensor"
-        assert leakage_sensor.get_leak_sensor_type() == None
-        assert leakage_sensor.get_leak_sensor_location() == None
+        assert leakage_sensor.get_leak_sensor_type() == 'unknown'
+        assert leakage_sensor.get_leak_sensor_location() == 'unknown'
         assert leakage_sensor.get_leak_severity() == LeakSeverity.CRITICAL
         assert leakage_sensor.is_leak() == False
 
@@ -72,7 +72,7 @@ def test_get_leak_sensor_type_default():
         Test get_leak_sensor_type default value is None
         '''
         sensor = LeakageSensorBase("sensor1")
-        assert sensor.get_leak_sensor_type() is None
+        assert sensor.get_leak_sensor_type() is 'unknown'
 
     @staticmethod
     def test_get_leak_sensor_type_set():
@@ -90,7 +90,7 @@ def test_get_leak_sensor_location_default():
         Test get_leak_sensor_location default value is None
         '''
         sensor = LeakageSensorBase("sensor1")
-        assert sensor.get_leak_sensor_location() is None
+        assert sensor.get_leak_sensor_location() is 'unknown'
 
     @staticmethod
     def test_get_leak_sensor_location_set():