Skip to content

Commit dff4f0c

Browse files
Fix the pipeline failures
Signed-off-by: saksarav <sakthivadivu.saravanaraj@nokia.com>
1 parent 99d354b commit dff4f0c

3 files changed

Lines changed: 9 additions & 7 deletions

File tree

meta/SaiSerialize.cpp

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -863,7 +863,8 @@ static std::string sai_serialize_flags(
863863

864864
std::string sai_serialize_enum(
865865
_In_ const int32_t value,
866-
_In_ const sai_enum_metadata_t* meta)
866+
_In_ const sai_enum_metadata_t* meta,
867+
bool flagCheck)
867868
{
868869
SWSS_LOG_ENTER();
869870

@@ -872,7 +873,7 @@ std::string sai_serialize_enum(
872873
return sai_serialize_number(value);
873874
}
874875

875-
if (meta->flagstype == SAI_ENUM_FLAGS_TYPE_STRICT)
876+
if ((flagCheck) && (meta->flagstype == SAI_ENUM_FLAGS_TYPE_STRICT))
876877
{
877878
return sai_serialize_flags(value, meta);
878879
}
@@ -3413,7 +3414,7 @@ json sai_serialize_stat_capability(
34133414

34143415
json j;
34153416

3416-
j["stat_enum"] = sai_serialize_enum(stat_capability.stat_enum, meta);
3417+
j["stat_enum"] = sai_serialize_enum(stat_capability.stat_enum, meta, false);
34173418

34183419
json arr = json::array();
34193420

meta/sai_serialize.h

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -254,7 +254,8 @@ std::string sai_serialize_switch_shutdown_request(
254254

255255
std::string sai_serialize_enum(
256256
_In_ const int32_t value,
257-
_In_ const sai_enum_metadata_t* meta);
257+
_In_ const sai_enum_metadata_t* meta,
258+
_In_ bool flagCheck = true);
258259

259260
std::string sai_serialize_enum_list(
260261
_In_ const sai_s32_list_t& list,

unittest/meta/TestSaiSerialize.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2060,8 +2060,8 @@ TEST(SaiDeserialize, sai_deserialize_enum)
20602060
sai_deserialize_enum("SAI_PORT_ERROR_STATUS_MAC_REMOTE_FAULT|SAI_PORT_ERROR_STATUS_DATA_UNIT_SIZE|0x80000", emd, value);
20612061
EXPECT_EQ(value, SAI_PORT_ERROR_STATUS_MAC_REMOTE_FAULT| SAI_PORT_ERROR_STATUS_DATA_UNIT_SIZE|0x80000);
20622062

2063-
sai_deserialize_enum("SAI_PORT_ERROR_STATUS_LOCAL_REMOTE_FAULT|SAI_PORT_ERROR_STATUS_DATA_UNIT_SIZE|0xe0000", emd, value);
2064-
EXPECT_EQ(value, SAI_PORT_ERROR_STATUS_MAC_REMOTE_FAULT| SAI_PORT_ERROR_STATUS_DATA_UNIT_SIZE|0xe0000);
2063+
sai_deserialize_enum("SAI_PORT_ERROR_STATUS_MAC_LOCAL_FAULT|SAI_PORT_ERROR_STATUS_DATA_UNIT_SIZE|0xe0000", emd, value);
2064+
EXPECT_EQ(value, SAI_PORT_ERROR_STATUS_MAC_LOCAL_FAULT| SAI_PORT_ERROR_STATUS_DATA_UNIT_SIZE|0xe0000);
20652065

20662066
sai_deserialize_enum("SAI_PORT_ERROR_STATUS_MAC_LOCAL_FAULT|SAI_PORT_ERROR_STATUS_DATA_UNIT_SIZE|"
20672067
"SAI_PORT_ERROR_STATUS_NO_RX_REACHABILITY|SAI_PORT_ERROR_STATUS_LLR_TX_FLUSH|0xff064000", emd, value);
@@ -2094,7 +2094,7 @@ TEST(SaiDeserialize, sai_deserialize_enum)
20942094
EXPECT_EQ(value, 0xf1230000);
20952095

20962096
sai_deserialize_enum("SAI_STATS_MODE_READ|", emd, value);
2097-
EXPECT_EQ(value, 0xf1230000);
2097+
EXPECT_EQ(value, SAI_STATS_MODE_READ);
20982098

20992099
// Not checking the syslog warning
21002100
sai_deserialize_enum("SAI_STATS_MODE_READ|SAI_STATS_MODE_WRITE", emd, value);

0 commit comments

Comments
 (0)