Skip to content

display proper message with proper errno for kvm.#3750

Merged
hdwhdw merged 7 commits into
sonic-net:masterfrom
hdwhdw:kvm
Feb 7, 2025
Merged

display proper message with proper errno for kvm.#3750
hdwhdw merged 7 commits into
sonic-net:masterfrom
hdwhdw:kvm

Conversation

@hdwhdw

@hdwhdw hdwhdw commented Feb 5, 2025

Copy link
Copy Markdown
Contributor

What I did

In KVM, there is no system EEPROM. decode-syseeprom should display the information and return the correct errno (ENODEV).

Currently, on KVM, decode-syseeprom will return OK (0) even if there is no system EEPROM.

How I did it

Check if the platform is kvm, if so, log and return.

How to verify it

root@vlab-01:~# decode-syseeprom
Platform x86_64-kvm_x86_64-r0 does not support EEPROM
root@vlab-01:~# echo $?
19
root@vlab-01:~# python3 -c 'import os, sys; print(os.strerror(int(sys.argv[1])))' 19
No such device

Previous command output (if the output of a command-line utility has changed)

admin@vlab-01:~$ sudo decode-syseeprom -s
Failed to read system EEPROM info
admin@vlab-01:~$ echo $?
0

New command output (if the output of a command-line utility has changed)

@mssonicbld

Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld

Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld

Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld

Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld

Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld

Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld

Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld

Copy link
Copy Markdown
Collaborator

Cherry-pick PR to msft-202412: Azure/sonic-utilities.msft#192

nmoray pushed a commit to nmoray/sonic-utilities that referenced this pull request Jun 25, 2025
* display proper message with proper errno for kvm.

* this change should cover all flags.

* add unit test.

* fix typo.

* fix unit test.

* whitespace EOF

* delete dead variable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants