Skip to content

[trim]: Add Packet Trimming Asym DSCP CLI#3920

Merged
qiluo-msft merged 1 commit into
sonic-net:masterfrom
nazariig:master-trim-asym
Jul 13, 2025
Merged

[trim]: Add Packet Trimming Asym DSCP CLI#3920
qiluo-msft merged 1 commit into
sonic-net:masterfrom
nazariig:master-trim-asym

Conversation

@nazariig

Copy link
Copy Markdown
Collaborator

Signed-off-by: Nazarii Hnydyn nazariig@nvidia.com

HLD: sonic-net/SONiC#1988

What I did

  • Implemented CLI for Packet Trimming Asymmetric DSCP feature

How I did it

  • Integrated Packet Trimming Asymmetric DSCP interface into config and show CLI root

How to verify it

  1. Run Packet Trimming CLI UTs

Previous command output (if the output of a command-line utility has changed)

admin@sonic:/home/admin# show switch-trimming global
+-----------------------------+---------+
| Configuration               | Value   |
+=============================+=========+
| Packet trimming size        | 256     |
+-----------------------------+---------+
| Packet trimming DSCP value  | 25      |
+-----------------------------+---------+
| Packet trimming queue index | 5       |
+-----------------------------+---------+

New command output (if the output of a command-line utility has changed)

admin@sonic:/home/admin# show switch-trimming global
+-----------------------------+---------+
| Configuration               | Value   |
+=============================+=========+
| Packet trimming size        | 256     |
+-----------------------------+---------+
| Packet trimming DSCP value  | from-tc |
+-----------------------------+---------+
| Packet trimming TC value    | 10      |
+-----------------------------+---------+
| Packet trimming queue index | 5       |
+-----------------------------+---------+

A picture of a cute animal (not mandatory but encouraged)

      .---.        .-----------
     /     \  __  /    ------
    / /     \(  )/    -----
   //////   ' \/ `   ---
  //// / // :    : ---
 // /   /  /`    '--
//          //..\\
       ====UU====UU====
           '//||\\`
             ''``

@mssonicbld

Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld

Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@nazariig nazariig marked this pull request as ready for review June 12, 2025 15:44
Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
@mssonicbld

Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@nazariig

nazariig commented Jul 8, 2025

Copy link
Copy Markdown
Collaborator Author

@kperumalbfn / @r12f can you please review this one?

@nazariig

Copy link
Copy Markdown
Collaborator Author

@kperumalbfn / @r12f just a kind reminder

@kperumalbfn kperumalbfn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@developfast

developfast commented Jul 10, 2025

Copy link
Copy Markdown
Contributor

sorry why are we introducing tc instead of dscp here? @nazariig

@kperumalbfn

Copy link
Copy Markdown
Contributor

sorry why are we introducing tc instead of dscp here? @nazariig

@developfast This is for Asymmetric DSCP support using TC value. Please check HLD - sonic-net/SONiC#1988

@nazariig nazariig requested review from prsunny and qiluo-msft July 11, 2025 17:24
@qiluo-msft qiluo-msft merged commit 09b4292 into sonic-net:master Jul 13, 2025
7 checks passed
@mssonicbld

Copy link
Copy Markdown
Collaborator

Cherry-pick PR to msft-202412: Azure/sonic-utilities.msft#202

@mssonicbld

Copy link
Copy Markdown
Collaborator

Cherry-pick PR to 202505: #3971

YairRaviv pushed a commit to YairRaviv/sonic-utilities that referenced this pull request Jan 12, 2026
HLD: sonic-net/SONiC#1988

What I did
Implemented CLI for Packet Trimming Asymmetric DSCP feature
How I did it
Integrated Packet Trimming Asymmetric DSCP interface into config and show CLI root
How to verify it
Run Packet Trimming CLI UTs
Previous command output (if the output of a command-line utility has changed)
admin@sonic:/home/admin# show switch-trimming global
+-----------------------------+---------+
| Configuration               | Value   |
+=============================+=========+
| Packet trimming size        | 256     |
+-----------------------------+---------+
| Packet trimming DSCP value  | 25      |
+-----------------------------+---------+
| Packet trimming queue index | 5       |
+-----------------------------+---------+
New command output (if the output of a command-line utility has changed)
admin@sonic:/home/admin# show switch-trimming global
+-----------------------------+---------+
| Configuration               | Value   |
+=============================+=========+
| Packet trimming size        | 256     |
+-----------------------------+---------+
| Packet trimming DSCP value  | from-tc |
+-----------------------------+---------+
| Packet trimming TC value    | 10      |
+-----------------------------+---------+
| Packet trimming queue index | 5       |
+-----------------------------+---------+
Yogapriya-cisco pushed a commit to vrajeshe/sonic-utilities that referenced this pull request Jul 10, 2026
HLD: sonic-net/SONiC#1988

What I did
Implemented CLI for Packet Trimming Asymmetric DSCP feature
How I did it
Integrated Packet Trimming Asymmetric DSCP interface into config and show CLI root
How to verify it
Run Packet Trimming CLI UTs
Previous command output (if the output of a command-line utility has changed)
admin@sonic:/home/admin# show switch-trimming global
+-----------------------------+---------+
| Configuration               | Value   |
+=============================+=========+
| Packet trimming size        | 256     |
+-----------------------------+---------+
| Packet trimming DSCP value  | 25      |
+-----------------------------+---------+
| Packet trimming queue index | 5       |
+-----------------------------+---------+
New command output (if the output of a command-line utility has changed)
admin@sonic:/home/admin# show switch-trimming global
+-----------------------------+---------+
| Configuration               | Value   |
+=============================+=========+
| Packet trimming size        | 256     |
+-----------------------------+---------+
| Packet trimming DSCP value  | from-tc |
+-----------------------------+---------+
| Packet trimming TC value    | 10      |
+-----------------------------+---------+
| Packet trimming queue index | 5       |
+-----------------------------+---------+

Signed-off-by: Yogapriya Mohankumar <ymohanku@cisco.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants