[console] improve picocom launch efficiency#4531
Merged
Merged
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
hehuang-nokia
force-pushed
the
dev_cons_feature
branch
from
May 8, 2026 15:54
3d33b4e to
2256e9b
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
hehuang-nokia
marked this pull request as ready for review
May 9, 2026 01:55
|
@Blueve @lizhijianrd Please help review |
9 tasks
Contributor
|
This PR will offload the centralized consutil/picocom implementation to a platform specific script. |
Blueve
previously requested changes
May 13, 2026
Blueve
left a comment
Blueve
left a comment
Contributor
There was a problem hiding this comment.
Hold until clarified the motivation of this change
hehuang-nokia
force-pushed
the
dev_cons_feature
branch
from
May 29, 2026 15:59
2256e9b to
0d73817
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
hehuang-nokia
force-pushed
the
dev_cons_feature
branch
from
May 29, 2026 17:46
0d73817 to
f98b65f
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
hehuang-nokia
force-pushed
the
dev_cons_feature
branch
from
June 1, 2026 21:08
f98b65f to
21d206f
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
hehuang-nokia
force-pushed
the
dev_cons_feature
branch
from
June 2, 2026 16:47
21d206f to
98879f5
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Refactor connect/main.py and consutil connect to share a new console_connect() helper in consutil/lib.py instead of connect shelling out to consutil connect via pexpect. Lower-level pexpect-based ConsolePortInfo.connect() is intentionally unchanged; the os.execvp / bash session script rework is deferred to a follow-up change. Signed-off-by: hehuang <henry.1.huang@nokia.com>
hehuang-nokia
force-pushed
the
dev_cons_feature
branch
from
June 4, 2026 17:31
98879f5 to
7d5637f
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
@Blueve the platform specific code are removed. |
lizhijianrd
dismissed
Blueve’s stale review
June 24, 2026 11:40
the platform specific code are removed.
lizhijianrd
approved these changes
Jun 24, 2026
Collaborator
|
Cherry-pick PR to msft-202603: Azure/sonic-utilities.msft#376 |
mssonicbld
added
Included in msft-202603 branch
and removed
Created PR to msft-202603 branch
labels
Yogapriya-cisco
pushed a commit
to vrajeshe/sonic-utilities
that referenced
this pull request
Jul 10, 2026
…sonic-net#4531) Refactor connect/main.py and consutil connect to share a new console_connect() helper in consutil/lib.py instead of connect shelling out to consutil connect via pexpect. Lower-level pexpect-based ConsolePortInfo.connect() is intentionally unchanged; the os.execvp / bash session script rework is deferred to a follow-up change. Signed-off-by: hehuang <henry.1.huang@nokia.com> Signed-off-by: Yogapriya Mohankumar <ymohanku@cisco.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
replace pexpect calls with direct function call and exec while preserving the original logic
What I did
streamlined the picocom launch process
How I did it
replaced the first pexpect call with a direct function call
wrapped the picocom launch in a bash script
replaced the second pexpect call with execvp
How to verify it
first, launch console app just like before
then, use ps -ef to make sure "connect line" is no longer a standalone process
Previous command output (if the output of a command-line utility has changed)
connect line X or just reverse ssh