[console] improve picocom launch efficiency#4531
Open
hehuang-nokia wants to merge 1 commit into
Open
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
replace pexpect calls with direct function call and exec while preserving the original logic Signed-off-by: hehuang <henry.1.huang@nokia.com>
hehuang-nokia
force-pushed
the
dev_cons_feature
branch
from
3d33b4e to
2256e9b
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@Blueve @lizhijianrd Please help review |
9 tasks
Contributor
|
This PR will offload the centralized consutil/picocom implementation to a platform specific script. |
Blueve
requested changes
May 13, 2026
Contributor
Blueve
left a comment
Blueve
left a comment
There was a problem hiding this comment.
Hold until clarified the motivation of this change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
replace pexpect calls with direct function call and exec while preserving the original logic
What I did
streamlined the picocom launch process
How I did it
replaced the first pexpect call with a direct function call
wrapped the picocom launch in a bash script
replaced the second pexpect call with execvp
How to verify it
first, launch console app just like before
then, use ps -ef to make sure "connect line" is no longer a standalone process
Previous command output (if the output of a command-line utility has changed)
connect line X or just reverse ssh