[nvidia bmc] add nvidia dump to the generate_dump utility#4573
Merged
Conversation
Signed-off-by: Yakiv Huryk <yhuryk@nvidia.com>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
oleksandrivantsiv
approved these changes
May 29, 2026
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
yxieca
approved these changes
Jun 10, 2026
yxieca
added
Request for msft-202608 Branch
Approved for msft-202608 Branch
and removed
Request for 202605 Branch
labels
yijingyan2
added
Approved for msft-202608 Branch
and removed
Approved for msft-202608 Branch
labels
Collaborator
|
Cherry-pick PR to msft-202608: Azure/sonic-utilities.msft#383 |
mssonicbld
added
Included in msft-202608 Branch
and removed
Created PR to msft-202608 Branch
labels
Yogapriya-cisco
pushed a commit
to vrajeshe/sonic-utilities
that referenced
this pull request
Jul 10, 2026
…4573) What: Adds collect_nvidia_bmc_dump() in scripts/generate_dump and invokes it from main() when asic=aspeed and platform contains "nvidia", saving /tmp/hw-mgmt-bmc-dump* into techsupport. Why: Extend show techsupport on the Nvidia BMC (aspeed) platform to include hw-management BMC dump artifacts for diagnostics. How: New bash function runs /usr/bin/hw-management-bmc-generate-dump.sh under timeout, handles missing script and timeout cases, saves artifacts via save_file and cleans up; main() resolves platform via sonic_py_common.device_info and gates the call on asic/platform. Testing: Azure.sonic-utilities pipeline green (Build Python3, BuildData, Pretest Static Analysis, coverage), Analyze (python), Semgrep, DCO, EasyCLA all pass. Two approvals (oleksandrivantsiv, yxieca). Signed-off-by: Yakiv Huryk <yhuryk@nvidia.com> Signed-off-by: Yogapriya Mohankumar <ymohanku@cisco.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Extended generate_dump / show techsupport on the Nvidia BMC (aspeed) platform with hw-management dump.
How I did it
Added
collect_nvidia_bmc_dump()inscripts/generate_dumpHow to verify it
Run
show techsupporton Nvidia BMC platform and check the techsupport.Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)