[202605] [sonic-package-manager]: Use lowercase 'azure/sonic' in registry reso…#4679
Merged
lunyue-ms merged 1 commit intoJul 13, 2026
Merged
Conversation
…lver test 'Azure/sonic' is not a valid lowercase Docker Hub reference; use 'azure/sonic' so test_get_registry_for passes regardless of the docker-image-py version. Signed-off-by: Lun Yue <17232861+lunyue-ms@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Collaborator
|
/azp run |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
saiarcot895
approved these changes
Jul 10, 2026
lunyue-ms
changed the title
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
On 202605,
test_get_registry_foruses the invalid referenceAzure/sonic, which fails underdocker-image-py0.2.0 (it treats the uppercase first path component as a registry domain). Fix the test to use the valid lowercaseazure/sonicso it passes regardless of thedocker-image-pyversion. (Test-only portion of #4655.)How I did it
tests/sonic_package_manager/test_registry.py:resolver.get_registry_for('Azure/sonic')→resolver.get_registry_for('azure/sonic').How to verify it
Run the package-manager registry test with
docker-image-py0.2.0 installed:It passes —
azure/sonicresolves to theDockerHubRegistrysingleton regardless of thedocker-image-pyversion.Previous command output (if the output of a command-line utility has changed)
N/A - no user-facing command output changes.
New command output (if the output of a command-line utility has changed)
N/A - no user-facing command output changes.