Skip to content

Fix ReShade shader repo fetching via MediaWiki API#1279

Open
zany130 wants to merge 8 commits into
sonic2kk:masterfrom
zany130:copilot/update-create-shader-repo-list-again
Open

Fix ReShade shader repo fetching via MediaWiki API#1279
zany130 wants to merge 8 commits into
sonic2kk:masterfrom
zany130:copilot/update-create-shader-repo-list-again

Conversation

@zany130
Copy link
Copy Markdown
Collaborator

@zany130 zany130 commented Dec 27, 2025

Summary

Fixes shader repository list generation by switching the ReShade repo fetch
to the MediaWiki API instead of scraping the HTML page.

Background

PCGamingWiki no longer reliably allows direct HTML fetching of the ReShade page.
This causes repolist.txt to remain empty and results in only the hardcoded
astrayfx entry being available (see #1275 ).

Changes

  • Replace the existing repo-fetch logic inside createShaderRepoList
    with a MediaWiki API–based implementation.
  • No new files or dependencies added.
  • Bash-only change limited to the createShaderRepoList function.
  • Uses jq (already an optional dependency) to parse MediaWiki API JSON.

Testing

  • Verified locally that repolist.txt is populated correctly.
  • Custom entries in repocustomlist.txt are now respected.

Copilot AI and others added 8 commits December 27, 2025 06:00
…fender filter

Co-authored-by: zany130 <25832539+zany130@users.noreply.github.com>
Co-authored-by: zany130 <25832539+zany130@users.noreply.github.com>
Co-authored-by: zany130 <25832539+zany130@users.noreply.github.com>
Co-authored-by: zany130 <25832539+zany130@users.noreply.github.com>
Co-authored-by: zany130 <25832539+zany130@users.noreply.github.com>
@zany130 zany130 marked this pull request as ready for review December 29, 2025 02:15
Copilot AI review requested due to automatic review settings December 29, 2025 02:15
@zany130
Copy link
Copy Markdown
Collaborator Author

zany130 commented Dec 29, 2025

Works great and actually fixed both the repos not being grabbed from PC gaming wiki and also fixes repos add to the custom repo file not downloading

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes ReShade shader repository list generation by replacing HTML scraping with the MediaWiki API for fetching data from PCGamingWiki. This change addresses reliability issues where direct HTML fetching was failing, resulting in empty repository lists.

Key Changes

  • Replaced HTML scraping with MediaWiki API-based fetching using jq for JSON parsing
  • Updated default ReShade version from 5.9.1 to 6.6.2
  • Converted repocustomlist.txt from a hardcoded entry file to a well-documented template

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
steamtinkerlaunch Updated version string to v14.0.20251227, changed default RSVERS to 6.6.2, and refactored createShaderRepoList function to use MediaWiki API with improved error handling and comment filtering
misc/repocustomlist.txt Transformed from containing a single hardcoded repository entry to a documented template with the example entry commented out

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread steamtinkerlaunch
else
writelog "WARN" "${FUNCNAME[0]} - jq is not available for JSON parsing - Shader repository list cannot be fetched from API"
fi

Copy link

Copilot AI Dec 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line contains trailing whitespace. Consider removing it for code cleanliness.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants