Fix ReShade shader repo fetching via MediaWiki API#1279
Conversation
…fender filter Co-authored-by: zany130 <25832539+zany130@users.noreply.github.com>
Co-authored-by: zany130 <25832539+zany130@users.noreply.github.com>
Co-authored-by: zany130 <25832539+zany130@users.noreply.github.com>
Co-authored-by: zany130 <25832539+zany130@users.noreply.github.com>
Co-authored-by: zany130 <25832539+zany130@users.noreply.github.com>
|
Works great and actually fixed both the repos not being grabbed from PC gaming wiki and also fixes repos add to the custom repo file not downloading |
There was a problem hiding this comment.
Pull request overview
This PR fixes ReShade shader repository list generation by replacing HTML scraping with the MediaWiki API for fetching data from PCGamingWiki. This change addresses reliability issues where direct HTML fetching was failing, resulting in empty repository lists.
Key Changes
- Replaced HTML scraping with MediaWiki API-based fetching using jq for JSON parsing
- Updated default ReShade version from 5.9.1 to 6.6.2
- Converted repocustomlist.txt from a hardcoded entry file to a well-documented template
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| steamtinkerlaunch | Updated version string to v14.0.20251227, changed default RSVERS to 6.6.2, and refactored createShaderRepoList function to use MediaWiki API with improved error handling and comment filtering |
| misc/repocustomlist.txt | Transformed from containing a single hardcoded repository entry to a documented template with the example entry commented out |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| else | ||
| writelog "WARN" "${FUNCNAME[0]} - jq is not available for JSON parsing - Shader repository list cannot be fetched from API" | ||
| fi | ||
|
|
There was a problem hiding this comment.
This line contains trailing whitespace. Consider removing it for code cleanliness.
Summary
Fixes shader repository list generation by switching the ReShade repo fetch
to the MediaWiki API instead of scraping the HTML page.
Background
PCGamingWiki no longer reliably allows direct HTML fetching of the ReShade page.
This causes
repolist.txtto remain empty and results in only the hardcodedastrayfxentry being available (see #1275 ).Changes
createShaderRepoListwith a MediaWiki API–based implementation.
Testing
repolist.txtis populated correctly.repocustomlist.txtare now respected.