Fix volume config handling. - #111
Merged
Merged
Conversation
squidbus
commented
Aug 15, 2025
squidbus
commented
Collaborator
- Music attenuation was not taking master volume into account, making music louder than it should be when the master volume is lowered.
- Saving the volume levels to the config was not working properly since again, it did not take into account the master volume adjustment. This is also just broken anyway because of the music attenuation patch overriding whatever music volume you set, so I just removed it completely for now, pending a proper options menu.
hyperbx
approved these changes
Aug 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.