Config: Voice Language#129
Merged
Merged
Conversation
Contributor
|
Glad to see this actually be added but the only issue I noticed is that if the game is played with a Japan region setting, a lot of the Japanese Config checks would just not work as intended in all non-Japanese regions, maybe adding a check for that just in case? |
Signed-off-by: Isaac Marovitz <isaacryu@icloud.com>
IsaacMarovitz
force-pushed
the
voice-lang
branch
from
August 19, 2025 10:53
5ba790e to
b412fd5
Compare
Signed-off-by: Isaac Marovitz <isaacryu@icloud.com>
hyperbx
approved these changes
Aug 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.