Implement dynamic movie aspect ratio#130
Merged
Merged
Conversation
IsaacMarovitz
self-requested a review
August 22, 2025 01:48
hyperbx
force-pushed
the
movie-aspect-ratio
branch
from
August 22, 2025 02:13
0d9a675 to
2382bca
Compare
hyperbx
marked this pull request as draft
August 22, 2025 02:25
hyperbx
marked this pull request as ready for review
August 22, 2025 19:07
IsaacMarovitz
requested changes
Aug 22, 2025
hyperbx
marked this pull request as draft
August 22, 2025 19:40
hyperbx
marked this pull request as ready for review
August 22, 2025 20:00
IsaacMarovitz
approved these changes
Aug 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows pre-rendered movies to adjust their aspect ratio to the viewport dynamically.
The title screen movie has a special case that allows it to crop at narrow aspect ratios. The rest of the movies will pillarbox or letterbox, bar the staff roll movies that are corrected within their own dimensions.
UI scaling is not handled in this PR, ignore any stretching there.
2560x1080 (21:9)
1440x900 (16:10)
1280x960 (4:3)