Fix lens flares not being occluded by geometry. - #172
Merged
Conversation
IsaacMarovitz
approved these changes
Sep 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds logic for handling conditional survey and conditional rendering states.
When conditional survey is enabled, shaders are given a spec constant telling them to record the number of fragment invocations into a side buffer. When conditional rendering is enabled, this side buffer is used to determine whether to discard fragments.
Additionally, the texture descriptor set max is decreased to 32768, as using the full 65536 was filling the descriptor heap on D3D12 and causing asserts trying to set up the descriptor set for the buffer. I just halved it to still be a nice number since we will never reach that many textures anyway.
Fixes #122