API Improvements

[IsaacMarovitz]

Adds a bunch of headers for mostly graphics and graphics adjacent things. Some are more researched than others.

[IsaacMarovitz]

These first two may be properties of the base class

[hyperbx]

There's a lot of empty classes in here, are these awaiting mappings or are they just here for the sake of it?

It makes me a bit uneasy given some of these mappings are incorrect at a glance, so I don't know if half of this stuff has even been tested.

[hyperbx]

Suggested change

	shared_ptr<T> make_shared(T* pointer,uint32_t vftable)
	shared_ptr<T> make_shared(T* pointer, uint32_t vftable)

[hyperbx]

Use official Lua variable names.

Suggested change

	xpointer<const char> m_pName;
	lua_CFunction m_Func;
	xpointer<const char> name;
	lua_CFunction func;

[hyperbx]

Suggested change

//.peb

[hyperbx]

Suggested change

	// No name left for type
	class EffectBankData
	{
	public:
	be<uint32_t> m_Field0; // 0x3E - no idea
	stdx::string m_DataName; // player_sonic
	// From .peb (raw converted since they released after)
	xpointer<void> m_Data1;
	xpointer<void> m_Data2;
	xpointer<void> m_Data3;
	stdx::map<stdx::string, be<uint32_t>> m_EffectDataIndices; // barrier_g = 0x23
	};
	struct EffectBankData
	{
	be<uint32_t> Field00;
	stdx::string Name;
	xpointer<void> pData1;
	xpointer<void> pData2;
	xpointer<void> pData3;
	stdx::map<stdx::string, be<uint32_t>> mEffectDataIndices;
	};

[hyperbx]

Place assertions below classes.

Suggested change

	MARATHON_ASSERT_OFFSETOF(EffectBankData, m_EffectDataIndices, 0x2C);
	MARATHON_ASSERT_SIZEOF(EffectBankData, 0x38);
	class EffectBank : public SoX::RefCountObject
	{
	public:
	xpointer<ParticleEngine> m_pParticleEngine;
	be<uint32_t> m_FieldC; // Index ?
	xpointer<EffectBankData> m_pEffectBankA;
	};
	MARATHON_ASSERT_SIZEOF(EffectBank, 0x14);
	class EffectBank : public SoX::RefCountObject
	{
	public:
	xpointer<ParticleEngine> m_pParticleEngine;
	be<uint32_t> m_Field0C; // Index?
	xpointer<EffectBankData> m_pEffectBankA;
	};
	MARATHON_ASSERT_OFFSETOF(EffectBankData, mEffectDataIndices, 0x2C);
	MARATHON_ASSERT_SIZEOF(EffectBankData, 0x38);
	MARATHON_ASSERT_SIZEOF(EffectBank, 0x14);

[hyperbx]

Suggested change

	class DocMarathonImp;
	struct SFXMatrixArrayCounted;
	struct SFXMatrixArrayNode;
	struct SFXMatrixArray;
	struct SFXMatrixArrayCounted
	{
	be<uint32_t> m_Capacity;
	};
	struct SFXMatrixArrayNode
	{
	xpointer<SoX::Math::Matrix4x4> m_pData[4];
	SFXMatrixArray* GetArray()
	{
	return reinterpret_cast<SFXMatrixArray*>((uint64_t*)((uint64_t)this - 4));
	}
	};
	struct SFXMatrixArray : SFXMatrixArrayCounted, SFXMatrixArrayNode
	{
	};
	struct SFXMatrixNodeArray;
	struct SFXMatrixNode
	{
	xpointer<SoX::Math::Matrix4x4> m_pData[4];
	SFXMatrixArray* GetArray()
	{
	return reinterpret_cast<SFXMatrixArray*>((uint8_t*)this - 4);
	}
	};
	struct SFXMatrixNodeArray
	{
	be<uint32_t> m_Length;
	SFXMatrixNode m_First;
	};

[hyperbx]

Suggested change

	be<uint32_t> fpFieldC; //some with capture0
	be<uint32_t> fpField10; //some with capture0, yes again
	be<uint32_t> fpField0C;
	be<uint32_t> fpField10;

[hyperbx]

Suggested change

	xpointer<SFXMatrixArrayNode> m_aSFXMatrices1;
	xpointer<SFXMatrixArrayNode> m_aSFXMatrices2;
	stdx::map<stdx::string, boost::shared_ptr<SoX::Engine::RenderProcess>> m_msspRenderProcess;
	xpointer<SFXMatrixNode> m_aSFXMatrices1;
	xpointer<SFXMatrixNode> m_aSFXMatrices2;
	stdx::map<stdx::string, boost::shared_ptr<SoX::Engine::RenderProcess>> m_mspRenderProcesses;

[hyperbx]

Suggested change

	MARATHON_ASSERT_OFFSETOF(SFXAgent, m_msspRenderProcess, 0x10);
	MARATHON_ASSERT_OFFSETOF(SFXAgent, m_mspRenderProcess, 0x10);

[hyperbx]

Missing offset assertions.

[hyperbx]

There's a lot of empty classes in here, are these awaiting mappings or are they just here for the sake of it?

It makes me a bit uneasy given some of these mappings are incorrect at a glance, so I don't know if half of this stuff has even been tested.

[hyperbx]

Closing as these changes should be merged in with work from other branches, rather than being one large PR.