Render Actions API#193
Merged
Merged
Conversation
Signed-off-by: Isaac Marovitz <isaacryu@icloud.com>
Signed-off-by: Isaac Marovitz <isaacryu@icloud.com>
IsaacMarovitz
temporarily deployed
to
external
November 7, 2025 05:08 — with
GitHub Actions
Inactive
IsaacMarovitz
temporarily deployed
to
external
November 7, 2025 06:04 — with
GitHub Actions
Inactive
IsaacMarovitz
temporarily deployed
to
external
November 7, 2025 06:17 — with
GitHub Actions
Inactive
Signed-off-by: Isaac Marovitz <isaacryu@icloud.com>
IsaacMarovitz
temporarily deployed
to
external
November 7, 2025 06:42 — with
GitHub Actions
Inactive
IsaacMarovitz
marked this pull request as ready for review
November 7, 2025 06:42
Signed-off-by: Isaac Marovitz <isaacryu@icloud.com>
IsaacMarovitz
temporarily deployed
to
external
November 7, 2025 06:49 — with
GitHub Actions
Inactive
hyperbx
requested changes
Nov 7, 2025
hyperbx
left a comment
Collaborator
There was a problem hiding this comment.
Move all size assertions below offset assertions.
Co-authored-by: Hyper <34012267+hyperbx@users.noreply.github.com>
IsaacMarovitz
temporarily deployed
to
external
November 7, 2025 06:56 — with
GitHub Actions
Inactive
IsaacMarovitz
temporarily deployed
to
external
November 7, 2025 07:16 — with
GitHub Actions
Inactive
Signed-off-by: Isaac Marovitz <isaacryu@icloud.com>
IsaacMarovitz
temporarily deployed
to
external
November 8, 2025 20:46 — with
GitHub Actions
Inactive
hyperbx
requested changes
Nov 13, 2025
hyperbx
left a comment
Collaborator
There was a problem hiding this comment.
Enums in the API must be prefixed with the name of the enum, as we don't support enum classes.
For example, in SetBlendMode.h:
Before
enum BlendMode
{
Opaque = 0,
Blend = 1,
Add = 2
};
After
enum BlendMode
{
BlendMode_Opaque = 0,
BlendMode_Blend = 1,
BlendMode_Add = 2
};
This should apply to all enums in this PR.
Signed-off-by: Isaac Marovitz <isaacryu@icloud.com>
IsaacMarovitz
temporarily deployed
to
external
November 13, 2025 05:20 — with
GitHub Actions
Inactive
hyperbx
requested changes
Nov 13, 2025
Co-authored-by: Hyper <34012267+hyperbx@users.noreply.github.com>
IsaacMarovitz
temporarily deployed
to
external
November 13, 2025 14:12 — with
GitHub Actions
Inactive
hyperbx
approved these changes
Nov 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The render graph is constructed by Lua with each command being mapped to one of these
RenderActiontypes. With this API we are free to view and modify the contents of the render graph without Lua modification. This has uses in both future modding applications, but also in patches and debug tools.