Skip to content

Fix cube texture view type. #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
IsaacMarovitz merged 1 commit into from
Jul 19, 2025
Merged

Fix cube texture view type. #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions MarathonRecomp/gpu/rhi/plume_vulkan.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,14 +281,14 @@ namespace plume {

static VkImageViewType toImageViewType(RenderTextureViewDimension dimension, uint16_t arraySize) {
switch (dimension) {
case RenderTextureViewDimension::TEXTURE_1D:
case RenderTextureViewDimension::TEXTURE_1D:
return arraySize > 1 ? VK_IMAGE_VIEW_TYPE_1D_ARRAY : VK_IMAGE_VIEW_TYPE_1D;
case RenderTextureViewDimension::TEXTURE_2D:
case RenderTextureViewDimension::TEXTURE_2D:
return arraySize > 1 ? VK_IMAGE_VIEW_TYPE_2D_ARRAY : VK_IMAGE_VIEW_TYPE_2D;
case RenderTextureViewDimension::TEXTURE_3D:
return VK_IMAGE_VIEW_TYPE_3D;
case RenderTextureViewDimension::TEXTURE_CUBE:
return arraySize > 1 ? VK_IMAGE_VIEW_TYPE_CUBE_ARRAY : VK_IMAGE_VIEW_TYPE_CUBE;
case RenderTextureViewDimension::TEXTURE_CUBE:
return arraySize > 6 ? VK_IMAGE_VIEW_TYPE_CUBE_ARRAY : VK_IMAGE_VIEW_TYPE_CUBE;
default:
assert(false && "Unknown resource dimension.");
return VK_IMAGE_VIEW_TYPE_MAX_ENUM;
Expand Down
Loading