feat: add firstMap parameter to server creation and deployment processes#254
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for an optional firstMap parameter so API clients can override the initial TF2 map on server startup, propagating that value from HTTP → core use case/context → cloud-provider deployments (AWS ECS, OCI Container Instances, Oracle VM + docker-compose).
Changes:
- Thread
firstMap?: stringthrough core (ServerManager,DeploymentContext,CreateServerForClient) and provider implementations (AWS/OCI/Oracle VM). - Expose
firstMaponPOST /api/servers(OpenAPI + route validation) and enqueue it in the background task payload. - Add tests across entrypoints, core, and providers to validate that the startup map override is applied.
Reviewed changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/providers/src/cloud-providers/oracle/utils/generateDockerCompose.ts | Adds firstMap override when generating docker-compose command for Oracle VM deployments. |
| packages/providers/src/cloud-providers/oracle/OracleVMManager.ts | Plumbs firstMap into docker-compose generation. |
| packages/providers/src/cloud-providers/oracle/OracleVMManager.test.ts | Adds test asserting docker-compose uses the overridden startup map. |
| packages/providers/src/cloud-providers/oracle/OCIServerManager.ts | Adds firstMap override for OCI Container Instance TF2 args. |
| packages/providers/src/cloud-providers/oracle/OCIServerManager.test.ts | Adds test asserting OCI args use the overridden map. |
| packages/providers/src/cloud-providers/aws/services/DefaultTaskDefinitionService.ts | Adds firstMap override for ECS task definition TF2 command args. |
| packages/providers/src/cloud-providers/aws/services/DefaultTaskDefinitionService.test.ts | Adds test asserting ECS task definition uses the overridden map. |
| packages/providers/src/cloud-providers/aws/AWSServerManager.ts | Threads firstMap into DeploymentContext. |
| packages/entrypoints/src/http/routes/swaggerOptions.ts | Documents firstMap in OpenAPI schema for CreateServerRequest. |
| packages/entrypoints/src/http/routes/servers/createServer.ts | Accepts/validates firstMap and passes it into enqueued task data. |
| packages/entrypoints/src/http/routes/servers/createServer.test.ts | Adds tests for valid/invalid firstMap request bodies. |
| packages/core/src/usecase/CreateServerForClient.ts | Adds firstMap to use case params and forwards it to deployServer. |
| packages/core/src/usecase/CreateServerForClient.test.ts | Adds test asserting firstMap is passed to deployServer. |
| packages/core/src/services/ServerManager.ts | Extends deployServer args to include optional firstMap. |
| packages/core/src/models/DeploymentContext.ts | Stores firstMap in the deployment context model. |
| packages/core/src/models/DeploymentContext.test.ts | Adds coverage for firstMap on DeploymentContext. |
| .github/agents/quickserver-contributor.agent.md | Removes tools/model metadata from the agent frontmatter. |
garrappachc
pushed a commit
to tf2pickup-org/tf2pickup
that referenced
this pull request
Mar 20, 2026
…first lobby (#556) The [QuickServer API](sonikro/TF2-QuickServer#254) now supports receiving the MAP the server should start with in the API.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows the API to receive the map the server will initialize at