Conversation
There was a problem hiding this comment.
Pull request overview
Adds support for a new QEL MGE server variant by introducing the mge_qel2_rc4 map configuration and wiring it into the variant selection/config system.
Changes:
- Added a new
mge_qel2_rc4section with multiple arena spawn configurations inmgemod_spawns.cfg. - Registered a new
qel-mgevariant inconfig/default.jsonpointing tomge_qel2_rc4. - Updated
.gitignoreto ensuremaps/mge_qel2_rc4.bspis tracked.
Reviewed changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated 13 comments.
| File | Description |
|---|---|
| variants/base/tf/addons/sourcemod/configs/mgemod_spawns.cfg | Adds spawn/arena definitions for the new mge_qel2_rc4 map. |
| config/default.json | Adds a qel-mge variant definition using mge_qel2_rc4 as the startup map. |
| .gitignore | Un-ignores the new BSP so it can be included in the repo/image build context. |
| "1" "4096 4700 -3191" 0 270 0" | ||
| "2" "5004 4024 -3231" 0 180 0" | ||
| "3" "4096 3244 -3191" 0 90 0" | ||
| "4" "3196 3920 -3239" 0 0 0" |
There was a problem hiding this comment.
All four spawn lines in this arena have mismatched quotes (each has an extra trailing quote after the angle values). This breaks the expected "idx" "x y z pitch yaw roll" format used elsewhere in mgemod_spawns.cfg and is likely to make the whole map section unreadable.
| "1" "-856 3266 -3330" 0 90 0" | ||
| "2" "-1152 4842 -3340" 0 270 0" | ||
| "3" "-1224 3922 -3400" 0 90 0" | ||
| "4" "-416 4078 -3556" 0 180 0" |
There was a problem hiding this comment.
These spawn lines have mismatched quoting (angles are outside the quoted value / extra trailing quote). This should match the standard format in this file: "idx" "x y z pitch yaw roll".
| } | ||
| "Ammomod MGE Small 2" | ||
| { | ||
| "1" "2414 725 -3794" 0 0 0" |
There was a problem hiding this comment.
Spawn slot 1 has the same malformed quoting as earlier arenas (value closes after Z, leaving angles outside the quoted string). This will likely break parsing for this arena.
| "1" "562 11624 -3188" 0 255 0" | ||
| "2" "562 10392 -3196" 0 105 0" | ||
| "3" "32 10436 10436" 0 75 0" |
There was a problem hiding this comment.
These spawn lines have mismatched quoting (angles outside the quoted value with trailing quotes). Additionally, spawn slot 3 has Z = 10436, which is wildly inconsistent with the other Z values in this arena (~ -3196) and is likely a typo that will place the spawn far out of bounds.
| "2" "-5432 1384 496 0 300 0 | ||
| "3" "-4432 1448 495 0 225 0 |
There was a problem hiding this comment.
Spawns 2 and 3 are missing their terminating quotes, which will break KeyValues parsing for the entire Baloo 1 arena block.
| "2" "-5432 1384 496 0 300 0 | |
| "3" "-4432 1448 495 0 225 0 | |
| "2" "-5432 1384 496 0 300 0" | |
| "3" "-4432 1448 495 0 225 0" |
| } | ||
| "Ammomod MGE 2" | ||
| { | ||
| "1" "4590 725 -3794" 0 0 0" |
There was a problem hiding this comment.
Spawn slot 1 is malformed here (same quoting issue as the other arenas: Z is quoted but angles are outside the quoted value with a trailing quote). This should be "1" "4590 725 -3794 0 0 0"-style formatting.
| "4" "-447 -768 -500" 0 90 0 | ||
| "5" "-1332 -644 -762 0 45 0" | ||
| "6" "-856 432 7762" 0 0 0" |
There was a problem hiding this comment.
There are KeyValues syntax issues here (missing closing quote on spawn 4, and spawn 6 has an extra trailing quote). Also, spawn 6’s Z value is 7762, which looks inconsistent with the other Z values in this arena (mostly around -500/-762) and may be a typo (e.g., an extra digit or missing minus). Fix the quoting and double-check the intended Z coordinate.
| { | ||
| "1" "-449 640 -3316" 0 270 0" | ||
| "2" "436 516 -3578" 0 225 0" | ||
| "3" "-40 -560 -762 0 180 0" |
There was a problem hiding this comment.
Spawn slot 3 uses Z = -762, which doesn’t match the rest of the spawns in this Granary Mid 2 arena (they’re around -3316/-3578). This looks like a copy/paste mistake and will likely spawn players on the wrong vertical level.
| "3" "-40 -560 -762 0 180 0" | |
| "3" "-40 -560 -3578 0 180 0" |
| "displayName": "QEL MGE", | ||
| "hostname": "QEL MGE | {region} @ TF2-QuickServer", | ||
| "guildId": "1291587765770649656", | ||
| "map": "mge_qel2_rc4" |
There was a problem hiding this comment.
This new MGE variant doesn’t set an image, so it will inherit variants.default.image (currently the standard competitive image). Since the existing mge-tf variant explicitly uses sonikro/fat-mge-tf:latest (and the repository has MGE-specific config under variants/fat-mge-tf/), this variant likely also needs to set the MGE image to ensure the mgemod stack is present/working.
| "map": "mge_qel2_rc4" | |
| "map": "mge_qel2_rc4", | |
| "image": "sonikro/fat-mge-tf:latest" |
| "1" "4096 4700 9 0 270 0" | ||
| "2" "5004 4024 -31" 0 180 0" | ||
| "3" "3196 3920 -39" 0 0 0" | ||
| "4" "4096 3244 9" 0 90 0" |
There was a problem hiding this comment.
The spawn entry values for slots 2–4 are not valid KeyValues strings: the position/angle tuple is split across quoted/unquoted segments (e.g., "2" "5004 4024 -31" 0 180 0"). These lines will likely fail to parse or produce incorrect spawn coordinates. Put all 6 numbers inside the single quoted value string, consistent with the rest of this file.
No description provided.