Conversation
There was a problem hiding this comment.
Pull request overview
Adds two new MGE maps (mge_worldchampionship_v5, mge_league_v2) to the repo and attempts to register their arena spawn configurations in the MGEMod spawn config.
Changes:
- Added spawn configuration blocks for
mge_worldchampionship_v5andmge_league_v2inmgemod_spawns.cfg. - Added the two
.bspmap files tracked via Git LFS. - Updated
.gitattributesto ensure the new.bspfiles use Git LFS.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| variants/base/tf/addons/sourcemod/configs/mgemod_spawns.cfg | Adds new spawn/arena definitions for the two MGE maps. |
| maps/mge_worldchampionship_v5.bsp | Adds the map BSP via Git LFS pointer. |
| maps/mge_league_v2.bsp | Adds the map BSP via Git LFS pointer. |
| .gitattributes | Configures Git LFS tracking for the new BSP files. |
| "gamemode" "mge" | ||
| "team_size" "1v1 2v2" | ||
| "frag_limit" "20" | ||
| "allowed_classes" "scout soldier demoman sniper" | ||
| "hp_multiplier" "1.25" | ||
| "early_leave_threshold" "3" |
There was a problem hiding this comment.
The added arenas for this map use a different KeyValues schema (e.g., "gamemode", "team_size", "frag_limit", "allowed_classes", etc.). This file’s documented/established format uses keys like "fraglimit", "classes", "hpratio", "earlyleave", "infammo", "showhp", "mindist", and expects spawn points ("1", "2", …) directly under the arena block. With the current schema, MGEMod is unlikely to find any valid spawns/options for these arenas. Please rewrite this section to match the existing mgemod_spawns.cfg format (see the nearby mge_league_v1 entries as an example).
| "gamemode" "mge" | ||
| "team_size" "1v1 2v2" | ||
| "frag_limit" "20" | ||
| "allowed_classes" "scout soldier demoman sniper" | ||
| "hp_multiplier" "1.25" | ||
| "early_leave_threshold" "3" | ||
| "infinite_ammo" "0" | ||
| "show_hp" "0" | ||
| "min_spawn_distance" "700" | ||
|
|
||
| "spawns" | ||
| { | ||
| "red" | ||
| { | ||
| "1" "-10710.000000 12100.000000 -3415.000000 0.000000 135.000000 0.000000" | ||
| "2" "-10905.000000 12105.000000 -3400.000000 0.000000 90.000000 0.000000" | ||
| "3" "-11210.000000 12105.000000 -3400.000000 0.000000 90.000000 0.000000" | ||
| } | ||
| "blu" | ||
| { | ||
| "1" "-11415.000000 13185.000000 -3415.000000 0.000000 -45.000000 0.000000" | ||
| "2" "-11200.000000 13185.000000 -3400.000000 0.000000 -90.000000 0.000000" | ||
| "3" "-10905.000000 13175.000000 -3400.000000 0.000000 -90.000000 0.000000" | ||
| } | ||
| } |
There was a problem hiding this comment.
Same issue as above for the mge_league_v2 arenas: this section uses non-standard keys ("frag_limit", "allowed_classes", "hp_multiplier", etc.) and a nested "spawns"/"red"/"blu" structure that doesn’t match the mgemod_spawns.cfg format described at the top of the file (and used everywhere else). Please convert these arenas to the existing flat format (numeric spawn keys + "fraglimit"/"classes"/"hpratio"/etc.).
| "gamemode" "mge" | |
| "team_size" "1v1 2v2" | |
| "frag_limit" "20" | |
| "allowed_classes" "scout soldier demoman sniper" | |
| "hp_multiplier" "1.25" | |
| "early_leave_threshold" "3" | |
| "infinite_ammo" "0" | |
| "show_hp" "0" | |
| "min_spawn_distance" "700" | |
| "spawns" | |
| { | |
| "red" | |
| { | |
| "1" "-10710.000000 12100.000000 -3415.000000 0.000000 135.000000 0.000000" | |
| "2" "-10905.000000 12105.000000 -3400.000000 0.000000 90.000000 0.000000" | |
| "3" "-11210.000000 12105.000000 -3400.000000 0.000000 90.000000 0.000000" | |
| } | |
| "blu" | |
| { | |
| "1" "-11415.000000 13185.000000 -3415.000000 0.000000 -45.000000 0.000000" | |
| "2" "-11200.000000 13185.000000 -3400.000000 0.000000 -90.000000 0.000000" | |
| "3" "-10905.000000 13175.000000 -3400.000000 0.000000 -90.000000 0.000000" | |
| } | |
| } | |
| "fraglimit" "20" | |
| "classes" "scout soldier demoman sniper" | |
| "hpratio" "1.25" | |
| "earlyleave" "3" | |
| "infammo" "0" | |
| "showhp" "0" | |
| "distance" "700" | |
| "1" "-10710.000000 12100.000000 -3415.000000 0.000000 135.000000 0.000000" | |
| "2" "-10905.000000 12105.000000 -3400.000000 0.000000 90.000000 0.000000" | |
| "3" "-11210.000000 12105.000000 -3400.000000 0.000000 90.000000 0.000000" | |
| "4" "-11415.000000 13185.000000 -3415.000000 0.000000 -45.000000 0.000000" | |
| "5" "-11200.000000 13185.000000 -3400.000000 0.000000 -90.000000 0.000000" | |
| "6" "-10905.000000 13175.000000 -3400.000000 0.000000 -90.000000 0.000000" |
No description provided.