chore: remove dead code OracleVMManager#281
Merged
Merged
Conversation
Agent-Logs-Url: https://github.com/sonikro/TF2-QuickServer/sessions/7a3f6402-37e6-4924-8930-16418047d4a0 Co-authored-by: sonikro <11502789+sonikro@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Remove dead code for OracleVMManager
chore: remove dead code OracleVMManager
May 17, 2026
sonikro
approved these changes
May 17, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the unused OracleVMManager class (and its test file), which has been fully superseded by OCIServerManager. The only remaining references were a commented-out block in the factory and a barrel re-export, both of which are also cleaned up.
Changes:
- Delete
OracleVMManager.tsandOracleVMManager.test.ts. - Remove the
OracleVMManagerimport and commented-out factory branch inServerManagerFactory.ts. - Drop the
OracleVMManagerre-export from the oracle barrel file.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/providers/src/services/ServerManagerFactory.ts | Removes dead import and commented-out fallback creation block. |
| packages/providers/src/cloud-providers/oracle/OracleVMManager.ts | Deletes the obsolete VM manager implementation. |
| packages/providers/src/cloud-providers/oracle/OracleVMManager.test.ts | Deletes the corresponding test file. |
| packages/providers/src/cloud-providers/oracle/index.ts | Removes the barrel re-export of the deleted class. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OracleVMManagerwas a 266-line Oracle VM implementation entirely superseded byOCIServerManager, kept alive only by a commented-out reference inServerManagerFactory.ts.Changes
OracleVMManager.tsandOracleVMManager.test.tsServerManagerFactory.ts: removed theOracleVMManagerimport and the dead commented-outreturn OracleVMManager.create(...)blockoracle/index.ts: removed theOracleVMManagerbarrel re-exportWarning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
npm.jsr.io/usr/local/bin/node node /usr/local/bin/npm install(dns block)If you need me to access, download, or install something from one of these locations, you can either: