Skip to content

tech debt #264: fix core -> providers import direction#282

Merged
sonikro merged 1 commit into
mainfrom
techdebt/264-core-import-direction
May 28, 2026
Merged

tech debt #264: fix core -> providers import direction#282
sonikro merged 1 commit into
mainfrom
techdebt/264-core-import-direction

Conversation

@sonikro

@sonikro sonikro commented May 28, 2026

Copy link
Copy Markdown
Owner

Summary

Fixes tech debt issue #264 by correcting dependency direction in core use cases.

Changes

Updated ServerManagerFactory imports in core use cases from @tf2qs/providers to @tf2qs/core:

  • packages/core/src/usecase/CreateServerForUser.ts
  • packages/core/src/usecase/DeleteServer.ts
  • packages/core/src/usecase/DeleteServerForUser.ts
  • packages/core/src/usecase/TerminateLongRunningServers.ts
  • packages/core/src/usecase/TerminatePendingServers.ts
  • packages/core/src/usecase/TerminateServersWithoutCredit.ts

Why

Core should not depend on providers in Clean Architecture. This change keeps dependency flow inward and uses the interface re-exported by core.

Closes #264

Copilot AI review requested due to automatic review settings May 28, 2026 22:38
@sonikro sonikro enabled auto-merge (rebase) May 28, 2026 22:39

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses tech debt by correcting core use case imports so they no longer depend on the providers package for ServerManagerFactory.

Changes:

  • Replaced @tf2qs/providers imports with @tf2qs/core in six core use cases.
  • Keeps dependency direction aligned with the intended core/provider layering.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/core/src/usecase/CreateServerForUser.ts Updates ServerManagerFactory import source.
packages/core/src/usecase/DeleteServer.ts Updates ServerManagerFactory import source.
packages/core/src/usecase/DeleteServerForUser.ts Updates ServerManagerFactory import source.
packages/core/src/usecase/TerminateLongRunningServers.ts Updates ServerManagerFactory import source.
packages/core/src/usecase/TerminatePendingServers.ts Updates ServerManagerFactory import source.
packages/core/src/usecase/TerminateServersWithoutCredit.ts Updates ServerManagerFactory import source.

@sonikro sonikro merged commit 58d5b3e into main May 28, 2026
10 checks passed
@sonikro sonikro deleted the techdebt/264-core-import-direction branch May 28, 2026 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Tech Debt] Fix Clean Architecture violation: Core use cases import ServerManagerFactory from @tf2qs/providers

2 participants