Skip to content

Commit afae3d3

Browse files
sonofmagicsonofmagic
committed
ci: relax e2e watch plugin budget
1 parent 56635f0 commit afae3d3

3 files changed

Lines changed: 22 additions & 22 deletions

File tree

‎.github/workflows/e2e-watch.yml‎

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ jobs:
8181
timeout_minutes: 60
8282
watch_timeout_ms: '600000'
8383
watch_poll_ms: '40'
84-
watch_max_plugin_process_ms: '500'
84+
watch_max_plugin_process_ms: '1500'
8585
watch_command_timeout_ms: '1500000'
8686
- os: macos-latest
8787
runner_label: macos
@@ -154,7 +154,7 @@ jobs:
154154
timeout_minutes: 40
155155
watch_timeout_ms: '280000'
156156
watch_poll_ms: '40'
157-
watch_max_plugin_process_ms: '500'
157+
watch_max_plugin_process_ms: '1500'
158158
watch_command_timeout_ms: '720000'
159159
- os: macos-latest
160160
runner_label: macos
@@ -254,7 +254,7 @@ jobs:
254254
timeout_minutes: 45
255255
watch_timeout_ms: '320000'
256256
watch_poll_ms: '40'
257-
watch_max_plugin_process_ms: '500'
257+
watch_max_plugin_process_ms: '1500'
258258
watch_command_timeout_ms: '840000'
259259
runs-on: ${{ matrix.os }}
260260
timeout-minutes: ${{ matrix.timeout_minutes }}
@@ -304,7 +304,7 @@ jobs:
304304
E2E_WATCH_CASE: ${{ matrix.watch_case }}
305305
E2E_WATCH_TIMEOUT_MS: ${{ matrix.watch_timeout_ms }}
306306
E2E_WATCH_POLL_MS: ${{ matrix.watch_poll_ms }}
307-
E2E_WATCH_MAX_PLUGIN_PROCESS_MS: ${{ matrix.watch_max_plugin_process_ms || '500' }}
307+
E2E_WATCH_MAX_PLUGIN_PROCESS_MS: ${{ matrix.watch_max_plugin_process_ms || '1500' }}
308308
E2E_WATCH_COMMAND_TIMEOUT_MS: ${{ matrix.watch_command_timeout_ms }}
309309
E2E_WATCH_MAX_ATTEMPTS: ${{ matrix.watch_max_attempts || '2' }}
310310
E2E_WATCH_ROUND_PROFILE: ${{ matrix.round_profile }}
@@ -370,7 +370,7 @@ jobs:
370370
timeout_minutes: 150
371371
watch_timeout_ms: '600000'
372372
watch_poll_ms: '40'
373-
watch_max_plugin_process_ms: '500'
373+
watch_max_plugin_process_ms: '1500'
374374
watch_command_timeout_ms: '7200000'
375375
- os: windows-latest
376376
runner_label: windows
@@ -380,7 +380,7 @@ jobs:
380380
timeout_minutes: 180
381381
watch_timeout_ms: '1200000'
382382
watch_poll_ms: '40'
383-
watch_max_plugin_process_ms: '500'
383+
watch_max_plugin_process_ms: '1500'
384384
watch_command_timeout_ms: '9000000'
385385
- os: macos-latest
386386
runner_label: macos
@@ -399,7 +399,7 @@ jobs:
399399
timeout_minutes: 60
400400
watch_timeout_ms: '600000'
401401
watch_poll_ms: '40'
402-
watch_max_plugin_process_ms: '500'
402+
watch_max_plugin_process_ms: '1500'
403403
watch_command_timeout_ms: '1500000'
404404
- os: macos-latest
405405
runner_label: macos
@@ -409,7 +409,7 @@ jobs:
409409
timeout_minutes: 120
410410
watch_timeout_ms: '420000'
411411
watch_poll_ms: '40'
412-
watch_max_plugin_process_ms: '500'
412+
watch_max_plugin_process_ms: '1500'
413413
watch_command_timeout_ms: '5400000'
414414
- os: windows-latest
415415
runner_label: windows
@@ -447,7 +447,7 @@ jobs:
447447
timeout_minutes: 60
448448
watch_timeout_ms: '600000'
449449
watch_poll_ms: '40'
450-
watch_max_plugin_process_ms: '500'
450+
watch_max_plugin_process_ms: '1500'
451451
watch_command_timeout_ms: '1500000'
452452
- os: windows-latest
453453
runner_label: windows
@@ -507,7 +507,7 @@ jobs:
507507
E2E_WATCH_CASE: ${{ matrix.watch_case }}
508508
E2E_WATCH_TIMEOUT_MS: ${{ matrix.watch_timeout_ms }}
509509
E2E_WATCH_POLL_MS: ${{ matrix.watch_poll_ms }}
510-
E2E_WATCH_MAX_PLUGIN_PROCESS_MS: ${{ matrix.watch_max_plugin_process_ms || '500' }}
510+
E2E_WATCH_MAX_PLUGIN_PROCESS_MS: ${{ matrix.watch_max_plugin_process_ms || '1500' }}
511511
E2E_WATCH_COMMAND_TIMEOUT_MS: ${{ matrix.watch_command_timeout_ms }}
512512
E2E_WATCH_MAX_ATTEMPTS: ${{ matrix.watch_max_attempts || '2' }}
513513
E2E_WATCH_ROUND_PROFILE: ${{ matrix.round_profile }}

‎packages/weapp-tailwindcss/test/ci/workflows.test.ts‎

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -250,7 +250,7 @@ describe('e2e watch workflow', () => {
250250
expect(stepRuns(workflow, 'nightly-full-regression')).toContain('pnpm e2e:watch')
251251
})
252252

253-
it('keeps strict plugin processing budgets for e2e watch rows while allowing longer startup timeouts', () => {
253+
it('keeps explicit plugin processing budgets for e2e watch rows while allowing longer startup timeouts', () => {
254254
const { workflow } = readWorkflow('e2e-watch.yml')
255255
const prRows: Array<Record<string, unknown>> = workflow.jobs['pr-quick-gate'].strategy.matrix.include
256256
const nightlyRows: Array<Record<string, unknown>> = workflow.jobs['nightly-full-regression'].strategy.matrix.include
@@ -262,7 +262,7 @@ describe('e2e watch workflow', () => {
262262
round_profile: 'issue33',
263263
timeout_minutes: 60,
264264
watch_timeout_ms: '600000',
265-
watch_max_plugin_process_ms: '500',
265+
watch_max_plugin_process_ms: '1500',
266266
watch_command_timeout_ms: '1500000',
267267
}
268268
const slowWindowsPrBudgets = [
@@ -331,15 +331,15 @@ describe('e2e watch workflow', () => {
331331
runner_label: 'macos',
332332
timeout_minutes: 40,
333333
watch_timeout_ms: '280000',
334-
watch_max_plugin_process_ms: '500',
334+
watch_max_plugin_process_ms: '1500',
335335
watch_command_timeout_ms: '720000',
336336
},
337337
{
338338
os: 'windows-latest',
339339
runner_label: 'windows',
340340
timeout_minutes: 45,
341341
watch_timeout_ms: '320000',
342-
watch_max_plugin_process_ms: '500',
342+
watch_max_plugin_process_ms: '1500',
343343
watch_command_timeout_ms: '840000',
344344
},
345345
]
@@ -378,7 +378,7 @@ describe('e2e watch workflow', () => {
378378
round_profile: 'default',
379379
timeout_minutes: 120,
380380
watch_timeout_ms: '420000',
381-
watch_max_plugin_process_ms: '500',
381+
watch_max_plugin_process_ms: '1500',
382382
watch_command_timeout_ms: '5400000',
383383
}))
384384
expect(nightlyRows).toContainEqual(expect.objectContaining({
@@ -406,12 +406,12 @@ describe('e2e watch workflow', () => {
406406
round_profile: 'default',
407407
timeout_minutes: 180,
408408
watch_timeout_ms: '1200000',
409-
watch_max_plugin_process_ms: '500',
409+
watch_max_plugin_process_ms: '1500',
410410
watch_command_timeout_ms: '9000000',
411411
}))
412412
})
413413

414-
it('keeps the default e2e watch plugin processing budget at 500ms', () => {
414+
it('keeps the CI e2e watch plugin processing fallback budget at 1500ms', () => {
415415
const { workflow } = readWorkflow('e2e-watch.yml')
416416

417417
const prRunStep = workflow.jobs['pr-quick-gate'].steps.find((step: Record<string, unknown>) => {
@@ -421,13 +421,13 @@ describe('e2e watch workflow', () => {
421421
return step.name === 'Run e2e watch suite (nightly/full)'
422422
})
423423

424-
expect(prRunStep.env.E2E_WATCH_MAX_PLUGIN_PROCESS_MS).toBe("${{ matrix.watch_max_plugin_process_ms || '500' }}")
425-
expect(nightlyRunStep.env.E2E_WATCH_MAX_PLUGIN_PROCESS_MS).toBe("${{ matrix.watch_max_plugin_process_ms || '500' }}")
424+
expect(prRunStep.env.E2E_WATCH_MAX_PLUGIN_PROCESS_MS).toBe("${{ matrix.watch_max_plugin_process_ms || '1500' }}")
425+
expect(nightlyRunStep.env.E2E_WATCH_MAX_PLUGIN_PROCESS_MS).toBe("${{ matrix.watch_max_plugin_process_ms || '1500' }}")
426426
expect(prRunStep.env.E2E_WATCH_MAX_ATTEMPTS).toBe("${{ matrix.watch_max_attempts || '2' }}")
427427
expect(nightlyRunStep.env.E2E_WATCH_MAX_ATTEMPTS).toBe("${{ matrix.watch_max_attempts || '2' }}")
428428
})
429429

430-
it('does not widen any e2e watch plugin processing matrix budget beyond 500ms', () => {
430+
it('keeps any explicit e2e watch plugin processing matrix budget within 1500ms', () => {
431431
const { workflow } = readWorkflow('e2e-watch.yml')
432432
const rows: Array<Record<string, unknown>> = [
433433
...workflow.jobs['pr-quick-gate'].strategy.matrix.include,
@@ -439,7 +439,7 @@ describe('e2e watch workflow', () => {
439439
if (budget == null) {
440440
continue
441441
}
442-
expect(Number(budget), `${row.runner_label}:${row.watch_case}:${row.round_profile}`).toBeLessThanOrEqual(500)
442+
expect(Number(budget), `${row.runner_label}:${row.watch_case}:${row.round_profile}`).toBeLessThanOrEqual(1500)
443443
}
444444
})
445445

‎packages/weapp-tailwindcss/test/watch-hmr-regression.unit.test.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1431,7 +1431,7 @@ describe('watch-hmr regression cases', () => {
14311431
expect(runSteps.length).toBe(2)
14321432
for (const step of runSteps) {
14331433
const env = step.env as Record<string, string> | undefined
1434-
expect(env?.E2E_WATCH_MAX_PLUGIN_PROCESS_MS).toBe("${{ matrix.watch_max_plugin_process_ms || '500' }}")
1434+
expect(env?.E2E_WATCH_MAX_PLUGIN_PROCESS_MS).toBe("${{ matrix.watch_max_plugin_process_ms || '1500' }}")
14351435
expect(env?.E2E_WATCH_MAX_ATTEMPTS).toBe("${{ matrix.watch_max_attempts || '2' }}")
14361436
expect(env?.NODE_OPTIONS).toBe('--max-old-space-size=6144')
14371437
}

0 commit comments

Comments
 (0)