Buffering bug fix.

[ultinous-dancsa]

Hi,
There is a bug in the readline buffering. If multiple line buffered, only the first line is being consumed, subsequent calls to readline wont consume the buffer until more bufferable input provided as the buffer consuming happens only after the select() and on select timeout, the readline returns with nil.

Please consider merging this PR.

Thanks,
Daniel

[sonots]

could you add tests?

[ultinous-dancsa]

I don't know what tests do you expect to this trivial patch. The original readline() implementation has a bug, easily reproduced by
echo -e "1st line\n2nd line" > pipe
the second line wont be presented to the caller till the next write, as the select() will return no new data.
This is a serious bug, as messages can be lost, or seriously delayed. The pr contains our fix, that is tested in our system, it works, but we can't provide unit tests for this patch.

[sonots]

Write the bad case you described as a unit test.
Without test, even if I merged this once, the plugin possibly can be broken after refactoring in the future.

[metacoma]

Hey folks, sorry about bump old thread, the master branch still have this issue, the code in Ultinous:master branch works fine.