Skip to content

Commit 11991d6

Browse files
committed
fix: revert default retention to Limits; set WorkQueue in drain test
Default stream retention stays Limits (broker-agnostic default). The enqueuePopAck_drainsStream test requires WorkQueue semantics so it now sets the policy explicitly on its own config, matching the pattern already used by JetStreamMessageBrokerPeekIT. Assisted-By: Claude Code
1 parent 76fe68f commit 11991d6

3 files changed

Lines changed: 5 additions & 3 deletions

File tree

rqueue-nats/src/main/java/com/github/sonus21/rqueue/nats/RqueueNatsConfig.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ public static RqueueNatsConfig defaults() {
5353
public static class StreamDefaults {
5454
private int replicas = 1;
5555
private StorageType storage = StorageType.File;
56-
private RetentionPolicy retention = RetentionPolicy.WorkQueue;
56+
private RetentionPolicy retention = RetentionPolicy.Limits;
5757
private Duration duplicateWindow = Duration.ofMinutes(2);
5858
private long maxMsgs = -1;
5959
private long maxBytes = -1;

rqueue-nats/src/test/java/com/github/sonus21/rqueue/nats/JetStreamMessageBrokerEnqueueAckIT.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,10 @@ class JetStreamMessageBrokerEnqueueAckIT extends AbstractJetStreamIT {
2626
@Test
2727
void enqueuePopAck_drainsStream() throws Exception {
2828
QueueDetail q = mockQueue("eaq-" + System.nanoTime());
29+
RqueueNatsConfig cfg = RqueueNatsConfig.defaults();
30+
cfg.getStreamDefaults().setRetention(io.nats.client.api.RetentionPolicy.WorkQueue);
2931
try (JetStreamMessageBroker broker =
30-
JetStreamMessageBroker.builder().connection(connection).build()) {
32+
JetStreamMessageBroker.builder().connection(connection).config(cfg).build()) {
3133
List<RqueueMessage> sent = new ArrayList<>();
3234
for (int i = 0; i < 10; i++) {
3335
RqueueMessage m =

rqueue-spring-boot-starter/src/main/java/com/github/sonus21/rqueue/spring/boot/RqueueNatsProperties.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ public static class Connection {
6666
public static class Stream {
6767
private int replicas = 1;
6868
private String storage = "FILE";
69-
private String retention = "WORKQUEUE";
69+
private String retention = "LIMITS";
7070
private Duration maxAge = Duration.ofDays(14);
7171
private long maxBytes = -1;
7272
private long maxMessages = -1;

0 commit comments

Comments
 (0)