Skip to content

Commit cdd246e

Browse files
committed
revert tool change
1 parent dacc586 commit cdd246e

6 files changed

Lines changed: 10 additions & 8 deletions

File tree

docs/configuration/configuration.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -196,7 +196,7 @@ The `DefaultRqueueMessageConverter` handles serialization for most use cases, bu
196196
may fail if classes are not shared between producing and consuming applications. To
197197
avoid shared dependencies, consider using JSON-based converters like
198198
`com.github.sonus21.rqueue.converter.JsonMessageConverter` or Spring's
199-
`MappingJackson2MessageConverter`. These serialize payloads into JSON, improving
199+
`JacksonJsonMessageConverter`. These serialize payloads into JSON, improving
200200
interoperability.
201201

202202
Other serialization formats like MessagePack or Protocol Buffers (ProtoBuf) can also
@@ -209,4 +209,3 @@ be implemented based on your requirements.
209209
subsequent poll. The default value is `1`. If increased to `N`, the message will
210210
be retried `N` times consecutively within the same polling cycle.
211211

212-

rqueue-core/build.gradle

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,6 @@ mavenPublishing {
4040
}
4141

4242
dependencies {
43-
// https://mvnrepository.com/artifact/com.fasterxml.jackson.core/jackson-core
4443
api "tools.jackson.core:jackson-core:${jacksonVersion}"
4544
api "tools.jackson.core:jackson-databind:${jacksonVersion}"
4645
api "com.fasterxml.jackson.core:jackson-annotations:${jacksonAnnotationsVersion}"

rqueue-core/src/main/java/com/github/sonus21/rqueue/converter/JsonMessageConverter.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@
2222
import lombok.extern.slf4j.Slf4j;
2323
import org.springframework.messaging.Message;
2424
import org.springframework.messaging.MessageHeaders;
25-
import org.springframework.messaging.converter.MappingJackson2MessageConverter;
2625
import org.springframework.messaging.converter.MessageConverter;
2726
import org.springframework.messaging.support.GenericMessage;
2827
import tools.jackson.core.JacksonException;
@@ -37,7 +36,7 @@
3736
* <p>Target class is null till the time method arguments are not resolved, once method arguments
3837
* are resolved then it will become non-null.
3938
*
40-
* @see MappingJackson2MessageConverter
39+
* @see org.springframework.messaging.converter.JacksonJsonMessageConverter
4140
*/
4241
@Slf4j
4342
public class JsonMessageConverter implements MessageConverter {

rqueue-core/src/main/java/com/github/sonus21/rqueue/converter/MessageConverterProvider.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
import com.github.sonus21.rqueue.core.DefaultRqueueMessageConverter;
2020
import org.springframework.messaging.Message;
2121
import org.springframework.messaging.converter.CompositeMessageConverter;
22+
import org.springframework.messaging.converter.JacksonJsonMessageConverter;
2223
import org.springframework.messaging.converter.MappingJackson2MessageConverter;
2324
import org.springframework.messaging.converter.MessageConverter;
2425
import org.springframework.messaging.converter.SmartMessageConverter;
@@ -40,6 +41,7 @@
4041
* @see CompositeMessageConverter
4142
* @see SmartMessageConverter
4243
* @see DefaultRqueueMessageConverter
44+
* @see JacksonJsonMessageConverter
4345
* @see MappingJackson2MessageConverter
4446
*/
4547
public interface MessageConverterProvider {

rqueue-core/src/test/java/com/github/sonus21/rqueue/converter/JsonMessageConverterTest.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,12 +31,15 @@
3131
import org.junit.jupiter.api.Test;
3232
import org.springframework.messaging.Message;
3333
import org.springframework.messaging.converter.MessageConverter;
34+
import tools.jackson.databind.DeserializationFeature;
3435
import tools.jackson.databind.ObjectMapper;
36+
import tools.jackson.databind.json.JsonMapper;
3537

3638
@CoreUnitTest
3739
class JsonMessageConverterTest extends TestBase {
3840

39-
private final ObjectMapper objectMapper = new ObjectMapper();
41+
private final ObjectMapper objectMapper =
42+
JsonMapper.builder().configure(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES, false).build();
4043
private final MessageConverter messageConverter = new JsonMessageConverter();
4144
private final MessageConverter messageConverter2 = new JsonMessageConverter(objectMapper);
4245

rqueue-spring-common-test/src/main/java/com/github/sonus21/rqueue/test/util/TestMessageConverterProvider.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,14 +16,14 @@
1616

1717
package com.github.sonus21.rqueue.test.util;
1818

19+
import com.github.sonus21.rqueue.converter.JsonMessageConverter;
1920
import com.github.sonus21.rqueue.converter.MessageConverterProvider;
20-
import org.springframework.messaging.converter.MappingJackson2MessageConverter;
2121
import org.springframework.messaging.converter.MessageConverter;
2222

2323
public class TestMessageConverterProvider implements MessageConverterProvider {
2424

2525
@Override
2626
public MessageConverter getConverter() {
27-
return new MappingJackson2MessageConverter();
27+
return new JsonMessageConverter();
2828
}
2929
}

0 commit comments

Comments
 (0)