Skip to content

Commit c01918d

Browse files
authored
Merge pull request #16 from GameLooks/refactor/use-logger-instead-of-console
refactor: replace console.log with structured Logger
2 parents dc67b04 + 1484180 commit c01918d

3 files changed

Lines changed: 11 additions & 5 deletions

File tree

src/core/system/System.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -190,7 +190,7 @@ class A {
190190
*/
191191
test(): void {
192192
try {
193-
console.log("console A");
193+
this.logger.debug("Test method called in class A");
194194
} catch (error) {
195195
this.logger.error("Error in class A test", error as Error);
196196
}
@@ -213,7 +213,7 @@ class B extends A {
213213
*/
214214
test(): void {
215215
try {
216-
console.log("console B");
216+
this.logger.debug("Test method called in class B");
217217
} catch (error) {
218218
this.logger.error("Error in class B test", error as Error);
219219
}

src/game/combat/Player.ts

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,9 @@ import { CallCenter } from "../../communication/messaging/CallCenter";
44
import { Folder } from "../../data/storage/Folder";
55
import { VariableValue } from "../../data/models/VariableValue";
66
import { FormulaData } from "../../data/metadata/FormulaData";
7+
import { createLogger } from "../../utils/Logger";
8+
9+
const logger = createLogger("game/combat/Player");
710

811
/**
912
* 参数信息接口
@@ -689,7 +692,7 @@ export class Player {
689692
if (obj != null) {
690693
obj.setValue(value);
691694
} else {
692-
console.log("没有找到属性");
695+
logger.warn("Property not found", { site });
693696
}
694697

695698
return value;
@@ -711,7 +714,7 @@ export class Player {
711714
return (fx.getBody(this.playerData, fx.parseAbsoluteAddress(site), value) as any)
712715
.getValue();
713716
} else {
714-
console.log("没有找到属性");
717+
logger.warn("Property not found", { site });
715718
}
716719
return 0;
717720
}

src/utils/index.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,10 @@
11
import { BasicBody } from "../data/models/BasicBody";
2+
import { createLogger } from "./Logger";
23
export { MathUtils } from "./MathUtils";
34
export * from "./MathUtils";
45

6+
const logger = createLogger("utils");
7+
58
/**
69
* 安全获取 BasicBody 对象的值
710
*
@@ -34,7 +37,7 @@ export function getCatchValue(
3437
try {
3538
value = body.getValue(name, row, col);
3639
} catch (e) {
37-
console.log(e);
40+
logger.error("Error getting value from BasicBody", e as Error);
3841
value = 0;
3942
}
4043
return value;

0 commit comments

Comments
 (0)