[FIX/#1624] SP3 솝레터 QA 수정사항 반영#1630
Merged
Merged
Conversation
- `SopletterMainTopBar`의 `onTopicClick` 콜백을 nullable 타입으로 변경하고, null일 경우 아이콘이 보이지 않도록 수정했습니다. - `SopletterMainScreen`에서 `routeTopicId`가 존재할 경우 토픽 아이콘을 숨기도록(null 전달) 변경했습니다.
- Replace `ic_btn_arrow_left` with `icon_chevron_left` in `SopletterMainTopBar`. - Remove unused `ic_btn_arrow_left.xml` drawable resource.
- `SopletterMessages` 도메인 모델 및 DTO, UI State에 `hasNormalTopic` 필드 추가 - `SopletterMapper` 및 `SopletterMainViewModel`에서 해당 필드 매핑 로직 추가 - `SopletterMainScreen`에서 `routeTopicId`가 없고 `hasNormalTopic`이 true일 때만 토픽 클릭이 가능하도록 로직 수정
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
Work Description ✏️
Screenshot 📸
Screen_recording_20260711_083822.mp4
Uncompleted Tasks 😅
To Reviewers 📢
topbar 를 통합해볼까 했으나,, 그러면 기존 탑바의 복잡도가 올라갈거 같아서 우선 두었습니다
아니면 trailingIcons 로 따로 컴포넌트 받을 수 있게 뚫어놓는것도 좋을거 같긴해요