[FEAT/#1629] SP3 마이페이지, 솝트로그 앰플리튜드 추가#1632
Merged
Merged
Conversation
seungjunGong
left a comment
seungjunGong
left a comment
Member
There was a problem hiding this comment.
리뷰남긴것만 수정해주심 좋을거 같아요 고생하셨습니다~
| override val type : EventType, | ||
| override val eventName : String | ||
| ):AnalyticsEvent { | ||
| VIEW_MYPAGE_MAIN(EventType.VIEW,"mapage_main"), |
Member
There was a problem hiding this comment.
p1: 여기 오타있는거 같아요
Suggested change
| VIEW_MYPAGE_MAIN(EventType.VIEW,"mapage_main"), | |
| VIEW_MYPAGE_MAIN(EventType.VIEW,"mypage_main"), |
| @@ -0,0 +1,9 @@ | |||
| import org.sopt.official.analytics.AnalyticsEvent | |||
Member
There was a problem hiding this comment.
해당 파일이 pakage 명이 안적혀 있는거 같아요
파일을 feature>soptlog 로 옮겨주시면 좋겠습니다!
| onItemClick = { viewModel.onAction(MyPageAction.RequestLogout) } | ||
| onItemClick = { | ||
| viewModel.onAction(MyPageAction.RequestLogout) | ||
| tracker.trackViewType(MypageAnalyticsEvent.CLICK_DONE_LOGOUT, viewType) |
Member
There was a problem hiding this comment.
p1: 플로우 설명에 모달 속 로그아웃 버튼 클릭시리 되어 있는데 현재는 로그아웃 세션을 클릭시 호출되어있는거 같아요 다이얼로그 로그아웃 버튼 클릭시점에 찍히도록수정해주시면 감사하겠습니다!
seungjunGong
approved these changes
Jul 14, 2026
seungjunGong
left a comment
seungjunGong
left a comment
Member
There was a problem hiding this comment.
최고최고 저도 메다닥 붙여보겠습니다 고생하셨어요~
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
Work Description ✏️
Screenshot 📸
Uncompleted Tasks 😅
To Reviewers 📢