Merge pull request #1280 from soramitsu/price-update-center

Price update center

Author: Viscount88

fearless.xcodeproj/project.pbxproj

@@ -5,17 +5,15 @@ protocol WalletBalanceBuilderProtocol {
     func buildBalance(
         for accountInfos: [ChainAssetKey: AccountInfo?],
         _ metaAccounts: [MetaAccountModel],
-        _ chainAssets: [ChainAsset],
-        _ prices: [PriceData]
+        _ chainAssets: [ChainAsset]
     ) -> [MetaAccountId: WalletBalanceInfo]?
 }
 
 final class WalletBalanceBuilder: WalletBalanceBuilderProtocol {
     func buildBalance(
         for accountInfos: [ChainAssetKey: AccountInfo?],
         _ metaAccounts: [MetaAccountModel],
-        _ chainAssets: [ChainAsset],
-        _ prices: [PriceData]
+        _ chainAssets: [ChainAsset]
     ) -> [MetaAccountId: WalletBalanceInfo]? {
         let walletBalanceMap = metaAccounts.reduce(
             [MetaAccountId: WalletBalanceInfo]()
@@ -27,8 +25,7 @@ final class WalletBalanceBuilder: WalletBalanceBuilderProtocol {
             let enabledAssetFiatBalanceInfo = countBalance(
                 for: enabledChainAssets,
                 wallet,
-                accountInfos,
-                prices
+                accountInfos
             )
 
             let enabledAssetFiatBalance = enabledAssetFiatBalanceInfo.totalBalance
@@ -48,7 +45,7 @@ final class WalletBalanceBuilder: WalletBalanceBuilderProtocol {
                 dayChangePercent: dayChangePercent.isNaN ? .zero : dayChangePercent,
                 dayChangeValue: totalDayChange,
                 currency: wallet.selectedCurrency,
-                prices: prices.filter { $0.currencyId == wallet.selectedCurrency.id },
+                prices: PriceDataHelper.prices(for: wallet.selectedCurrency, from: chainAssets),
                 accountInfos: accountInfos
             )
 
@@ -63,8 +60,7 @@ final class WalletBalanceBuilder: WalletBalanceBuilderProtocol {
     private func countBalance(
         for chainAssets: [ChainAsset],
         _ metaAccount: MetaAccountModel,
-        _ accountInfos: [ChainAssetKey: AccountInfo?],
-        _ prices: [PriceData]
+        _ accountInfos: [ChainAssetKey: AccountInfo?]
     ) -> CountBalanceInfo {
         var accountInfosCount = 0
         var totalBalance: Decimal = .zero
@@ -84,7 +80,6 @@ final class WalletBalanceBuilder: WalletBalanceBuilderProtocol {
             let balance = getFiatBalance(
                 for: chainAsset,
                 accountInfo,
-                prices,
                 currency: metaAccount.selectedCurrency
             )
 
@@ -126,16 +121,14 @@ final class WalletBalanceBuilder: WalletBalanceBuilderProtocol {
     private func getFiatBalance(
         for chainAsset: ChainAsset,
         _ accountInfo: AccountInfo?,
-        _ prices: [PriceData],
         currency: Currency
     ) -> AssetFiatBalanceInfo {
         let balanceDecimal = getBalance(
             for: chainAsset,
             accountInfo
         )
 
-        guard let priceId = chainAsset.asset.priceId,
-              let priceData = prices.first(where: { $0.priceId == priceId && $0.currencyId == currency.id }),
+        guard let priceData = chainAsset.asset.getPrice(for: currency),
               let priceDecimal = Decimal(string: priceData.price)
         else {
             return AssetFiatBalanceInfo(total: .zero, dayChange: .zero)

fearless.xcworkspace/xcshareddata/swiftpm/Package.resolved

@@ -62,13 +62,8 @@ enum WalletBalanceListenerType {
 final class WalletBalanceSubscriptionAdapter: WalletBalanceSubscriptionAdapterProtocol, ChainAssetListBuilder {
     static let shared = createWalletBalanceAdapter()
 
-    // MARK: - PriceLocalStorageSubscriber
-
-    private let priceLocalSubscriber: PriceLocalStorageSubscriber
-
     // MARK: - Private properties
 
-    private var pricesProvider: AnySingleValueProvider<[PriceData]>?
     private lazy var walletBalanceBuilder = {
         WalletBalanceBuilder()
     }()
@@ -84,7 +79,6 @@ final class WalletBalanceSubscriptionAdapter: WalletBalanceSubscriptionAdapterPr
     private lazy var accountInfos: [ChainAssetKey: AccountInfo?] = [:]
     private lazy var chainAssets: [ChainAsset] = []
     private lazy var wallets: [MetaAccountModel] = []
-    private lazy var prices: [PriceData] = []
 
     private let listenersLock = ReaderWriterLock()
     private let accountInfoWorkQueue = DispatchQueue(
@@ -96,13 +90,11 @@ final class WalletBalanceSubscriptionAdapter: WalletBalanceSubscriptionAdapterPr
 
     private init(
         metaAccountRepository: AsyncAnyRepository<MetaAccountModel>,
-        priceLocalSubscriber: PriceLocalStorageSubscriber,
         chainAssetFetcher: ChainAssetFetchingProtocol,
         eventCenter: EventCenterProtocol,
         logger: Logger,
         accountInfoFetchingProvider: AccountInfoFetchingProtocol
     ) {
-        self.priceLocalSubscriber = priceLocalSubscriber
         walletRepository = metaAccountRepository
         self.chainAssetFetcher = chainAssetFetcher
         self.eventCenter = eventCenter
@@ -212,8 +204,7 @@ final class WalletBalanceSubscriptionAdapter: WalletBalanceSubscriptionAdapterPr
         let walletBalances = walletBalanceBuilder.buildBalance(
             for: accountInfos,
             wallets,
-            chainAssets,
-            prices
+            chainAssets
         )
         return walletBalances
     }
@@ -222,8 +213,6 @@ final class WalletBalanceSubscriptionAdapter: WalletBalanceSubscriptionAdapterPr
         self.chainAssets = chainAssets
         self.wallets = (self.wallets + wallets).uniq(predicate: { $0.metaId })
         subscribeToAccountInfo(for: wallets, chainAssets)
-        let currencies = self.wallets.map { $0.selectedCurrency }
-        subscribeToPrices(for: chainAssets, currencies: currencies)
     }
 
     private func fetchInitialData() {
@@ -294,14 +283,6 @@ final class WalletBalanceSubscriptionAdapter: WalletBalanceSubscriptionAdapterPr
         }
     }
 
-    private func subscribeToPrices(for chainAssets: [ChainAsset], currencies: [Currency]?) {
-        var uniqueQurrencies: [Currency]? = currencies
-        if let currencies = currencies {
-            uniqueQurrencies = Array(Set(currencies))
-        }
-        pricesProvider = priceLocalSubscriber.subscribeToPrices(for: chainAssets, currencies: uniqueQurrencies, listener: self)
-    }
-
     private func notify(
         listener: WalletBalanceSubscriptionListener,
         result: WalletBalancesResult
@@ -395,8 +376,6 @@ extension WalletBalanceSubscriptionAdapter: EventVisitorProtocol {
            let wallet = wallets[safe: index] {
             if wallet.selectedCurrency != event.account.selectedCurrency {
                 wallets[index] = event.account
-                let currencies = wallets.map { $0.selectedCurrency }
-                subscribeToPrices(for: chainAssets, currencies: currencies)
             }
             if wallet.networkManagmentFilter != event.account.networkManagmentFilter {
                 wallets[index] = event.account
@@ -432,6 +411,17 @@ extension WalletBalanceSubscriptionAdapter: EventVisitorProtocol {
             subscribeToAccountInfo(for: wallets, chainAssets)
         }
     }
+
+    func processPricesUpdated() {
+        Task {
+            self.chainAssets = try await chainAssetFetcher.fetchAwait(
+                shouldUseCache: false,
+                filters: [.enabledChains],
+                sortDescriptors: []
+            )
+            buildAndNotifyIfNeeded(with: wallets.map { $0.metaId }, updatedChainAssets: chainAssets)
+        }
+    }
 }
 
 // MARK: - AccountInfoSubscriptionAdapterHandler
@@ -464,32 +454,6 @@ extension WalletBalanceSubscriptionAdapter: AccountInfoSubscriptionAdapterHandle
     }
 }
 
-// MARK: - PriceLocalSubscriptionHandler
-
-extension WalletBalanceSubscriptionAdapter: PriceLocalSubscriptionHandler {
-    func handlePrices(result: Result<[PriceData], Error>) {
-        switch result {
-        case let .success(prices):
-            self.prices = prices
-            buildAndNotifyIfNeeded(with: wallets.map { $0.metaId }, updatedChainAssets: chainAssets)
-        case let .failure(error):
-            let unwrappedListeners = listenersLock.concurrentlyRead {
-                listeners.compactMap {
-                    if let target = $0.target as? WalletBalanceSubscriptionListener {
-                        return target
-                    }
-
-                    return nil
-                }
-            }
-            unwrappedListeners.forEach { listener in
-                notify(listener: listener, result: .failure(error))
-            }
-            logger.error("WalletBalanceFetcher error: \(error.localizedDescription)")
-        }
-    }
-}
-
 private extension WalletBalanceSubscriptionAdapter {
     static func createWalletBalanceAdapter() -> WalletBalanceSubscriptionAdapter {
         let chainRepository = ChainRepositoryFactory().createRepository(
@@ -498,7 +462,6 @@ private extension WalletBalanceSubscriptionAdapter {
         )
         let accountRepositoryFactory = AccountRepositoryFactory(storageFacade: UserDataStorageFacade.shared)
         let accountRepositoryAsync = accountRepositoryFactory.createAsyncMetaAccountRepository(for: nil, sortDescriptors: [])
-        let priceLocalSubscriber = PriceLocalStorageSubscriberImpl.shared
 
         let chainAssetFetching = ChainAssetsFetching(
             chainRepository: AnyDataProviderRepository(chainRepository),
@@ -519,7 +482,6 @@ private extension WalletBalanceSubscriptionAdapter {
 
         return WalletBalanceSubscriptionAdapter(
             metaAccountRepository: accountRepositoryAsync,
-            priceLocalSubscriber: priceLocalSubscriber,
             chainAssetFetcher: chainAssetFetching,
             eventCenter: EventCenter.shared,
             logger: logger,

fearless/ApplicationLayer/Services/Balance/WalletBalanceSubscription/WalletBalanceBuilder.swift

@@ -194,15 +194,7 @@ final class PriceLocalStorageSubscriberImpl: PriceLocalStorageSubscriber {
                     && wrapper.currencies.contains(where: { $0.id == price.currencyId }) == true
             }
 
-            switch wrapper.handler {
-            case .price:
-                guard let chainAsset = wrapper.chainAssets.first, let priceData = finalValue.first else {
-                    return
-                }
-                listener.handlePrice(result: .success(priceData), chainAsset: chainAsset)
-            case .prices:
-                listener.handlePrices(result: .success(finalValue))
-            }
+            listener.handlePrices(result: .success(finalValue), for: wrapper.chainAssets)
         }
     }
 
@@ -211,11 +203,7 @@ final class PriceLocalStorageSubscriberImpl: PriceLocalStorageSubscriber {
             guard let listener = wrapper.listener.target as? PriceLocalSubscriptionHandler else {
                 return
             }
-            if wrapper.chainAssets.count == 1, let chainAsset = wrapper.chainAssets.first {
-                listener.handlePrice(result: .failure(error), chainAsset: chainAsset)
-            } else {
-                listener.handlePrices(result: .failure(error))
-            }
+            listener.handlePrices(result: .failure(error), for: wrapper.chainAssets)
         }
     }
 

fearless/ApplicationLayer/Services/Balance/WalletBalanceSubscription/WalletBalanceSubscriptionAdapter.swift

@@ -2,21 +2,7 @@ import Foundation
 import SSFModels
 
 protocol PriceLocalSubscriptionHandler: AnyObject {
-    func handlePrice(
-        result: Result<PriceData?, Error>,
-        chainAsset: ChainAsset
-    )
-
-    func handlePrices(result: Result<[PriceData], Error>)
-}
-
-extension PriceLocalSubscriptionHandler {
-    func handlePrices(result _: Result<[PriceData], Error>) {}
-
-    func handlePrice(
-        result _: Result<PriceData?, Error>,
-        chainAsset _: ChainAsset
-    ) {}
+    func handlePrices(result: Result<[PriceData], Error>, for chainAssets: [ChainAsset])
 }
 
 extension CrowdloanLocalSubscriptionHandler {

fearless/Common/DataProvider/Subscription/PriceLocalStorageSubscriber.swift

@@ -28,6 +28,7 @@ protocol EventVisitorProtocol: AnyObject {
     func processChainsSetupCompleted()
     func processLogout()
     func processAccountScoreSettingsChanged()
+    func processPricesUpdated()
 }
 
 extension EventVisitorProtocol {
@@ -58,4 +59,5 @@ extension EventVisitorProtocol {
     func processChainsSetupCompleted() {}
     func processLogout() {}
     func processAccountScoreSettingsChanged() {}
+    func processPricesUpdated() {}
 }

fearless/Common/DataProvider/Subscription/PriceLocalSubscriptionHandler.swift

@@ -0,0 +1,7 @@
+import Foundation
+
+struct PricesUpdated: EventProtocol {
+    func accept(visitor: any EventVisitorProtocol) {
+        visitor.processPricesUpdated()
+    }
+}