Fix jax.random.categorical axis parameter for JAX 0.10.1 compatibility#1314
Open
jmr wants to merge 1 commit into
Open
Fix jax.random.categorical axis parameter for JAX 0.10.1 compatibility#1314jmr wants to merge 1 commit into
jmr wants to merge 1 commit into
Conversation
`jax.random.categorical` now strictly validates the `axis` parameter against the actual rank of the logits array. Passing `axis=1` on a 1D legal_action_mask raised `IndexError: index 1 is out of bounds for axis 0 with size 1`, breaking `test_api` across all games. Fix by using `axis=-1`, which selects the last axis and works correctly for both unbatched (1D) and batched (2D) inputs. See: https://docs.jax.dev/en/latest/_autosummary/jax.random.categorical.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jax.random.categoricalnow strictly validates theaxisparameter against the actual rank of the logits array. Passingaxis=1on a 1D legal_action_mask raisedIndexError: index 1 is out of bounds for axis 0 with size 1, breakingtest_apiacross all games.Fix by using
axis=-1, which selects the last axis and works correctly for both unbatched (1D) and batched (2D) inputs.See: https://docs.jax.dev/en/latest/_autosummary/jax.random.categorical.html