Skip to content

Commit 4e29210

Browse files
committed
chore: rename payment event classes for clarity and update references
1 parent 059f335 commit 4e29210

File tree

7 files changed

+21
-21
lines changed

7 files changed

+21
-21
lines changed
Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
package com.acme.payment;
2+
3+
public record PaymentConfirmedEvent(Payment payment) {
4+
}

src/main/java/com/acme/payment/PaymentErrorEvent.java

Lines changed: 0 additions & 4 deletions
This file was deleted.
Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
package com.acme.payment;
2+
3+
public record PaymentFailedEvent(Payment payment) {
4+
}

src/main/java/com/acme/payment/PaymentStatusService.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,15 +22,15 @@ class PaymentStatusService {
2222
this.repository = null;
2323
}
2424

25-
void payed(@Observes PaymentSuccessEvent event) {
25+
void payed(@Observes PaymentConfirmedEvent event) {
2626
LOGGER.info("Payment " + event.payment().getId() + " was payed");
2727
var payment = repository.findById(event.payment().getId()).orElseThrow();
2828
payment.confirmed();
2929
repository.save(payment);
3030
LOGGER.info("Payment " + payment.getId() + " was confirmed");
3131
}
3232

33-
void errorOnPayment(@Observes PaymentErrorEvent event) {
33+
void errorOnPayment(@Observes PaymentFailedEvent event) {
3434
LOGGER.info("Payment " + event.payment().getId() + " failed");
3535
var payment = repository.findById(event.payment().getId()).orElseThrow();
3636
payment.failed();

src/main/java/com/acme/payment/PaymentSuccessEvent.java

Lines changed: 0 additions & 4 deletions
This file was deleted.

src/main/java/com/acme/payment/provider/PaymentProvider.java

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
package com.acme.payment.provider;
22

3-
import com.acme.payment.PaymentErrorEvent;
3+
import com.acme.payment.PaymentFailedEvent;
44
import com.acme.payment.PaymentRequestedEvent;
5-
import com.acme.payment.PaymentSuccessEvent;
5+
import com.acme.payment.PaymentConfirmedEvent;
66
import jakarta.enterprise.context.ApplicationScoped;
77
import jakarta.enterprise.event.Event;
88
import jakarta.enterprise.event.ObservesAsync;
@@ -18,12 +18,12 @@ class PaymentProvider {
1818

1919
private final AtomicLong counter = new AtomicLong();
2020

21-
private final Event<PaymentSuccessEvent> successEvent;
21+
private final Event<PaymentConfirmedEvent> successEvent;
2222

23-
private final Event<PaymentErrorEvent> errorEvent;
23+
private final Event<PaymentFailedEvent> errorEvent;
2424

2525
@Inject
26-
PaymentProvider(Event<PaymentSuccessEvent> successEvent, Event<PaymentErrorEvent> errorEvent) {
26+
PaymentProvider(Event<PaymentConfirmedEvent> successEvent, Event<PaymentFailedEvent> errorEvent) {
2727
this.successEvent = successEvent;
2828
this.errorEvent = errorEvent;
2929
}
@@ -42,10 +42,10 @@ void receivePayment(@ObservesAsync PaymentRequestedEvent event) {
4242
}
4343
if(counter.get() % 2 == 0) {
4444
LOGGER.warning("Payment failed: " + event.payment().getId());
45-
errorEvent.fire(new PaymentErrorEvent(event.payment()));
45+
errorEvent.fire(new PaymentFailedEvent(event.payment()));
4646
} else {
4747
LOGGER.info("Payment successful: " + event.payment().getId());
48-
successEvent.fire(new PaymentSuccessEvent(event.payment()));
48+
successEvent.fire(new PaymentConfirmedEvent(event.payment()));
4949
}
5050
LOGGER.info("Payment processed: " + event.payment().getId() + " - Confirmation #" + counter.incrementAndGet());
5151
}

src/main/java/com/acme/statistics/PaymentCounterService.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@
22

33
import com.acme.Product;
44
import com.acme.payment.Payment;
5-
import com.acme.payment.PaymentErrorEvent;
6-
import com.acme.payment.PaymentSuccessEvent;
5+
import com.acme.payment.PaymentFailedEvent;
6+
import com.acme.payment.PaymentConfirmedEvent;
77
import jakarta.data.Order;
88
import jakarta.data.Sort;
99
import jakarta.data.page.Page;
@@ -33,7 +33,7 @@ public class PaymentCounterService {
3333
this.repository = null;
3434
}
3535

36-
void success(@Observes PaymentSuccessEvent event) {
36+
void success(@Observes PaymentConfirmedEvent event) {
3737
LOGGER.info("Payment successful, incrementing counter: " + event.payment().getId());
3838
Payment payment = event.payment();
3939
Product product = payment.getProduct();
@@ -43,7 +43,7 @@ void success(@Observes PaymentSuccessEvent event) {
4343
}
4444

4545

46-
void success(@Observes PaymentErrorEvent event) {
46+
void success(@Observes PaymentFailedEvent event) {
4747
LOGGER.info("Payment failed, incrementing counter: " + event.payment().getId());
4848
Payment payment = event.payment();
4949
Product product = payment.getProduct();

0 commit comments

Comments
 (0)