Stabilize the fingerprint#50
Merged
soul-catcher merged 1 commit intosoul-catcher:mainfrom Mar 31, 2025
Merged
Conversation
OokamiTheLord
approved these changes
Mar 12, 2025
Owner
|
Thank you for opening pull request! But I think adding a line of code to fingerprint is not an optimal solution for several reasons:
Also this adds requirement to have access to source code files. I decided to look at how other tools, such as Ruff, solve this problem, and found them solution really elegant. Fingerprint is based on:
I think this is the best way. Could you implement it in this pull request? |
2823df2 to
ca36b19
Compare
Contributor
Author
|
@soul-catcher Thanks for the feedback! I just adapted this PR. The error level and code are kept in the fingerprint to hash the full message. |
ca36b19 to
9090f61
Compare
Remove the line number from fingerprint. If the same fingerprint is already used for another issue in the same file, generate another one. This is more stable compared to the line number itself, which changes whenever code is added or removed above the issue.
9090f61 to
934e0f5
Compare
Owner
|
I checked this in my private Gitlab repo and it works perfectly! Thank you! |
Contributor
Author
|
Awesome. Thanks for merging and creating a new release! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the line number from fingerprint. If the same fingerprint is already used for another issue in the same file, generate another one. This is more stable compared to the line number itself, which changes whenever code is added or removed above the issue.