Skip to content

fix: XSS via taint analysis #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
soulteary merged 1 commit into from
Mar 8, 2026
Merged

fix: XSS via taint analysis #127

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions internal/server/server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -464,6 +464,7 @@ func executeCapturingHook(w http.ResponseWriter, ctx context.Context, matchedHoo
logger.Errorf("[%s] hook %s execution failed (command: %s): %v, output captured", requestID, hookID, matchedHook.ExecuteCommand, err)
w.Header().Set("Content-Type", "text/plain; charset=utf-8")
w.WriteHeader(http.StatusInternalServerError)
// #nosec G705 -- response is command stdout/stderr, returned as text/plain; not interpreted as HTML
_, _ = fmt.Fprint(w, response)
} else {
// 为了保持向后兼容性，使用特定的错误消息
Expand All @@ -484,10 +485,12 @@ func executeCapturingHook(w http.ResponseWriter, ctx context.Context, matchedHoo
// 记录审计日志：执行成功
audit.LogHookExecuted(requestID, hookID, ip, userAgent, durationMS)

w.Header().Set("Content-Type", "text/plain; charset=utf-8")
// Check if a success return code is configured for the hook
if matchedHook.SuccessHttpResponseCode != 0 {
writeHttpResponseCode(w, requestID, matchedHook.ID, matchedHook.SuccessHttpResponseCode)
}
// #nosec G705 -- response is command stdout/stderr, returned as text/plain; not interpreted as HTML
_, _ = fmt.Fprint(w, response)
}
}
Expand Down
Loading