Avoid IndexOutOfRangeException during mesh extraction and submesh removal#60
Open
rikochet9 wants to merge 1 commit into
Open
Avoid IndexOutOfRangeException during mesh extraction and submesh removal#60rikochet9 wants to merge 1 commit into
rikochet9 wants to merge 1 commit into
Conversation
…iangles they report instead of relying on the mesh description's claimed number, which can be inaccurate and result in a crash.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MeshUtil.cs: When working with submeshes, use the actual number of triangles they report instead of relying on the mesh description's claimed number, which can be inaccurate and result in a crash.
The Problem
For unknown reasons, submesh descriptors can sometimes report an incorrect number of indices. Attempting to iterate using these numbers results in an out of range exception. See detailed example below.
The Solution
Instead of getting all the mesh's triangles and iterating through a subset inferred from the submesh descriptor, get the triangles for that specific submesh and iterate through them as normal. This ensures the index is always in range.
Example
Crash:

In this case, it attempted to iterate up to index 190,935 of an array with only 92,202 objects because of numbers the mesh description reported:
