regression in sound: currently not audible (conductor and non-conductor)

[martin-henz]

Prerequisites

current source academy: https://sourceacademy.org/playground

Expected Behavior

import {make_sound, play } from 'sound';

const click = make_sound(t => math_sin(math_PI * t * 500), 1);

play(click);

should play a sound. Testing with sourceacademy.nus.edu.sg confirms my sound system is working.

Current Behavior

No sound

Failure Information (for bugs)

No console error.

Steps to Reproduce

Run the program above or.

[leeyi45]

This is related to the operators-fix PR that I have open with js-slang. Basically all user defined functions can't be called directly. The code for play doesn't perform a type check when calculating the sound, which is why the failure is silent.

Will be fixed by #607

[martin-henz]

Great. Thanks!