Conversation
# Conflicts: # lib/buildtools/src/build/__tests__/all.test.ts # lib/lintplugin/package.json # lib/modules-lib/src/tabs/__tests__/useAnimation.test.ts # package.json # yarn.lock
…y it as a dependency
# Conflicts: # yarn.lock
# Conflicts: # yarn.lock
Contributor
Author
|
Something very weird is happening with this PR Across the three different environments that I have access to (Windows, MacOS and the Github Actions) everything seems to be behaving inconsistently
This'll probably warrant more investigation on my end.... |
Contributor
Author
|
I am still considering introducing the validator in this PR, but I think I will probably have to leave it for another PR. There's a bunch of design decisions for it that need to be made. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Better Type Errors
Some general fixes to things that got missed out in previous PRs. Also re-exports
js-slang's rttc (runtime type checking) utilities and exposes them to modulesthrow-runtime-errorIntroduces a linting rule as well to highlight whenever an error being thrown doesn't inherit from the RuntimeSourceError type.
Devserver Changes
Since
js-slangnow allows us to customize what importers are being used, the devserver can now be used without the modules server.copy_gcandmark_sweeprefactorI modernized those two modules to bring them up to date with module contexts and other design patterns. They are sorely lacking in documentation however, so I don't actually know if anything is broken.
noImplicitAnynoImplicitAnyhas been enabled for all bundles and tabs and only left disabled for modules (likeunity_academy) that simply don't leave enough context clues or documentation for me to be able to create types for them. I've fixed type errors wherever I can, but a lot of bundles don't have tests so it's not always clear if any kind of functionality has been affected.